1815452 - Pass the sourceMap data between (pretty print, sourcemap) workers and main thread instead of an array of mappings

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

This would make pretty-printing significantly faster as we won't spend so much time in postMessage

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1815452 - [devtools] Simplify mapping structure posted to/from workers. r=bomsy!,ochameau.

We used to get the mappings array from the pretty fast worker to the prettyPrint
action, and then pass this array to the sourceMap service (also a worker).
As the mapping can be quite large, and given it has a complex shape, passing it
to and from workers (via postMessage) was costly.

So here, instead of passing only the mapping, we directly generate the sourceMap
from the pretty fast worker, and pass it to the action which forwards it to
the sourceMap service.

This helps reduce the overhead we were seeing when not buffering the lines in
the pretty print worker, in the previous patch of this stack.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c7ab0bb6a0e
[devtools] Simplify mapping structure posted to/from workers. r=ochameau,bomsy.

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2c7ab0bb6a0e