Closed
Bug 1815452
Opened 10 months ago
Closed 10 months ago
Pass the sourceMap data between (pretty print, sourcemap) workers and main thread instead of an array of mappings
Categories
(DevTools :: Debugger, task)
DevTools
Debugger
Tracking
(firefox111 fixed)
RESOLVED
FIXED
111 Branch
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
Attachments
(1 file)
This would make pretty-printing significantly faster as we won't spend so much time in postMessage
Assignee | ||
Comment 1•10 months ago
|
||
We used to get the mappings array from the pretty fast worker to the prettyPrint
action, and then pass this array to the sourceMap service (also a worker).
As the mapping can be quite large, and given it has a complex shape, passing it
to and from workers (via postMessage
) was costly.
So here, instead of passing only the mapping, we directly generate the sourceMap
from the pretty fast worker, and pass it to the action which forwards it to
the sourceMap service.
This helps reduce the overhead we were seeing when not buffering the lines in
the pretty print worker, in the previous patch of this stack.
Updated•10 months ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2c7ab0bb6a0e [devtools] Simplify mapping structure posted to/from workers. r=ochameau,bomsy.
Comment 3•10 months ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox111:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•