NetworkObserver: group early response callbacks in addResponseStarted
Categories
(DevTools :: Netmonitor, task, P1)
Tracking
(firefox113 fixed)
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [webdriver:m6])
Attachments
(1 file, 1 obsolete file)
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Comment 1•1 year ago
|
||
Depends on D168791
|
|
Assignee | |
Comment 2•1 year ago
|
||
Depends on D168791
resource ids are channel ids and should be incrementally generated. The current id is actually an actor id, meaning it is a string which will lead to incorrect comparisons (eg "Actor10" will be considered "lower" than "Actor2") and also fully depends on the order in which we create the actors.
On some platform / configurations we get identical timestamps for batches of requests, so the fallback mechanism should be reliable
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7765cf9b63f5 [devtools] Netmonitor waterfall sort should fallback to resource ids r=ochameau,bomsy,devtools-reviewers https://hg.mozilla.org/integration/autoland/rev/14ac0e2bcccb [devtools] Merge addRequestPostData, addResponseHeaders, addResponseCookies into addResponseStart r=webdriver-reviewers,ochameau,bomsy,devtools-reviewers,whimboo
|
||
Comment 4•1 year ago
|
||
Backed out for netmonitor devtools failures.
- backout: https://hg.mozilla.org/integration/autoland/rev/97b5b8a2256a203a5b930d6490b383c4dfa599d2
- push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=DVO8pFpfRByGyQwXeaAu6w.0&revision=14ac0e2bcccb091666ef39c7336f8184e4aff305
- failures can be seen here: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=DVO8pFpfRByGyQwXeaAu6w.0&revision=0dc8af92d56cb4f2d1452561acef2d75a69663be&searchStr=windows%2C11%2Cx64%2C22h2%2Cwebrender%2Copt%2Cmochitests%2Ctest-windows11-64-2009-qr%2Fopt-mochitest-devtools-chrome%2Cdt4 - there are different failures but within the netmonitor area.
|
||
Updated•1 year ago
|
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b7a170b0aa10 [devtools] Merge addRequestPostData, addResponseHeaders, addResponseCookies into addResponseStart r=webdriver-reviewers,ochameau,bomsy,devtools-reviewers,whimboo
|
|
Assignee | |
Comment 6•1 year ago
|
||
I removed the patch Bug 1815460 - [devtools] Netmonitor waterfall sort should fallback to resource ids.
Weirdly this was avoiding issues on Windows 10 test platforms, but seems to create more issues on windows 11.
Overall the netmonitor tests are flaky because they assume a request order which is not actually guaranteed by the test, and windows platforms seem to very often "bundle" requests together and fire them at the exact same timestamps.
|
||
Comment 7•1 year ago
|
||
| bugherder | ||
Description
•