1815509 - Reuse fixup result from frontend instead of fixing up multiple times when going through RemoteWebNavigation and/or tabbrowser's loadURI

Status: NEW

(Firefox :: Tabbed Browser, task)

Description

[:Gijs (out for now; he/him)]

In bug 1810141 I'm making loadURI actually take a URI and creating fixupAndLoadURIString to take a string.

Presently practically all frontend-initiated loads use a string.

A lot of frontend code ends up needing a URI, e.g. to do speculative connect or other things. Various bits of frontend code duplicate this logic and work, and then docshell/browsingcontext duplicates it some more.

I tried to consolidate some of it in bug 1810141 but it's hard to reason about in the middle of the refactor and it's risky. So doing it separately from the refactor seems valuable. This follows feedback from Marco in https://phabricator.services.mozilla.com/D168390#inline-930690 and https://phabricator.services.mozilla.com/D168392#inline-930244 and Nika in https://phabricator.services.mozilla.com/D168391#inline-929534 . Instead of moving the fixup to frontend code and making it call loadURI directly (or in addition to doing so), we could also consider passing in a fixup URI object on loadURIOptions so the fixup info remains available.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.