1815511 - Revise false positive tests using VideoFrame in SharedWorker

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, defect, P1)

Description

[C.M.Chang[:chunmin]]

The js code in sharedWorkerCode here

worker.port.postMessage({frame: frame, transfer: false});

and here

worker.port.postMessage({frame: frame, transfer: true});

should be replaced by:

worker.port.postMessage(frame);

and

worker.port.postMessage(frame, [frame]);

Otherwise, it gives us false positive results: e.data.toString() will never be '[object VideoFrame]' (e.data.frame.toString() can be).

Gecko should throw DataClonedError when deserializing a VideoFrame in SharedWorker. It will be fixed in bug 1815519.

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1815511 - Correct false positive tests using VideoFrame in SharedWorker

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1815511 - Ensure VideoFrame is unavailable in shared or service worker

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/027b0fc4f855
Correct false positive tests using VideoFrame in SharedWorker r=smaug
https://hg.mozilla.org/integration/autoland/rev/cbd58866b931
Ensure VideoFrame is unavailable in shared or service worker r=smaug

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38501 for changes under testing/web-platform/tests

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/027b0fc4f855
https://hg.mozilla.org/mozilla-central/rev/cbd58866b931

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot