Closed Bug 1815526 Opened 1 year ago Closed 1 year ago

Make sure to clean up :focus-visible as well as :focus for shadow hosts.

Categories

(Core :: DOM: Forms, defect)

defect

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

No description provided.

This is supposed to be cleaned up by the datetime widget in:

https://searchfox.org/mozilla-central/rev/188d0f76a73e0671d12e744a71e9f5701668cc37/toolkit/content/widgets/datetimebox.js#600,623

But that may never happen if we tear down the widget before via a type
change, and we don't quite want to unconditionally unfocus when tearing
down (we might want to close the picker, but that's a separate issue).

Make sure to always unset :focus-visible as well from shadow roots to
fix it, and add exhaustive tests.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bf8a49b2b6a
Make sure to clean up :focus-visible as well as :focus for shadow hosts. r=smaug
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38396 for changes under testing/web-platform/tests
Regressions: 1815569
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Upstream PR merged by moz-wptsync-bot
See Also: → 1803614
Blocks: 1320127
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: