messages with non-existing or misspelled group names silently fail to record impressions for that group
Categories
(Firefox :: Messaging System, defect, P3)
Tracking
()
People
(Reporter: dmosedale, Unassigned, NeedInfo)
References
Details
In the process of getting bug 1805470 verified, it became clear that if a group name in a messaging system message does not exist in the message-groups provider, adding an impression for that group silently does not happen:
is some of the code involved.
When this happens, we want to log something to the JS console so that whoever is working on the message/experiment/rollout can tell that there's a problem and have some clue about what debugging is needed.
A somewhat-related question (knowing the answer is not required to fix this bug, however): groups can be intentionally disabled via prefs and there is code around that treats missing/not-enabled groups as valid, but I'm not really sure what the use case for that is. Does anyone know?
|
Reporter | |
Comment 1•2 years ago
|
||
The question, however, does influence where this warning wants to go, since the problem here may not be limited to recording impressions.
|
|
Reporter | |
Comment 2•2 years ago
•
|
||
The more I think about it, the more I suspect that we should warn about this at message-provider load time, though that might require waiting for the message-groups provider load to complete first (if that's not already the case).
|
||
Updated•2 years ago
|
|
||
Comment 3•2 years ago
|
||
The severity field is not set for this bug.
:tspurway, could you have a look please?
For more information, please visit auto_nag documentation.
|
|
||
Comment 4•2 years ago
|
||
Redirect a needinfo that is pending on an inactive user to the triage owner.
:lsmith, since the bug doesn't have a severity set, could you please set the severity or close the bug?
For more information, please visit BugBot documentation.
Description
•