1815538 - Add an option to generate an entry trampoline for each script executing in the vm and baseline Interpreter

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P3)

Description

[Denis Palmeiro [:denispal]]

Generating an entry trampoline for each script whenever we enter the Interpreter or Baseline Interpreter will help distinguish what JS functions are being executed when profiling with perf.

Right now, all Interpreter & Baseline Interpreter executions are labelled under "Interpret" or "Baseline Interpreter", but if we can generate some entry stubs then we can see what functions are being executed on the call stack and it would be much easier to analyze Interpreter performance using perf.

v8 has a similar option --interpreted-frames-native-stack which does this (see https://v8.dev/docs/linux-perf#v8-linux-perf-flags)

Comment 1

[Denis Palmeiro [:denispal]]

Attachment: WIP: Bug 1815538: WIP Emit Interpreter entry stubs under --enable-perf

Comment 2

[Denis Palmeiro [:denispal]]

Attachment: WIP: Bug 1815538: WIP Emit Baseline Interpreter entry stubs under --enable-perf

Depends on D171870

Comment 3

[Denis Palmeiro [:denispal]]

Attachment: Bug 1815538: part 1 - Add a new JIT frame for baseline interpreter entry trampolines r=iain

Comment 4

[Denis Palmeiro [:denispal]]

Attachment: Bug 1815538: part 2 - Add an option to toggle emitting interpreter entry trampolines r=iain

Depends on D172630

Comment 5

[Denis Palmeiro [:denispal]]

Attachment: Bug 1815538: part 3 - Extend perf spewer range recorder to add script tags r=iain

Depends on D172631

Comment 6

[Denis Palmeiro [:denispal]]

Attachment: Bug 1815538: part 4 - Add a hash map in the JitRuntime to cache interpreter entry trampolines r=jonco

Depends on D172632

Comment 7

[Denis Palmeiro [:denispal]]

Attachment: Bug 1815538: part 5 - Emit an entry trampoline for each script that enters the baseline interpreter r=iain

Depends on D172633

Comment 8

[Denis Palmeiro [:denispal]]

Attachment: Bug 1815538: part 6 - Emit an entry trampoline for each script that enters the C++ interpreter r=iain

Depends on D172634

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa84801d3135
part 1 - Add a new JIT frame for baseline interpreter entry trampolines r=iain
https://hg.mozilla.org/integration/autoland/rev/58591987a7e3
part 2 - Add an option to toggle emitting interpreter entry trampolines r=iain
https://hg.mozilla.org/integration/autoland/rev/248aac5d3e98
part 3 - Extend perf spewer range recorder to add script tags r=iain
https://hg.mozilla.org/integration/autoland/rev/abe4af2213bc
part 4 - Add a hash map in the JitRuntime to cache interpreter entry trampolines r=jonco
https://hg.mozilla.org/integration/autoland/rev/5e173bc15da3
part 5 - Emit an entry trampoline for each script that enters the baseline interpreter r=iain
https://hg.mozilla.org/integration/autoland/rev/279822089dce
part 6 - Emit an entry trampoline for each script that enters the C++ interpreter r=iain

Comment 10

[Cristian Tuns]

Backed out for causing spidermonkey bustages in GC.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/js/src/gc/GC.cpp:4923:46: error: member access into incomplete type 'js::jit::JitRuntime'

hybrid bustages: https://treeherder.mozilla.org/logviewer?job_id=411510701&repo=autoland

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0af592aed892
part 1 - Add a new JIT frame for baseline interpreter entry trampolines r=iain
https://hg.mozilla.org/integration/autoland/rev/85831bb256a9
part 2 - Add an option to toggle emitting interpreter entry trampolines r=iain
https://hg.mozilla.org/integration/autoland/rev/27dd48c17e15
part 3 - Extend perf spewer range recorder to add script tags r=iain
https://hg.mozilla.org/integration/autoland/rev/5736319db66d
part 4 - Add a hash map in the JitRuntime to cache interpreter entry trampolines r=jonco
https://hg.mozilla.org/integration/autoland/rev/76fe7cc09a39
part 5 - Emit an entry trampoline for each script that enters the baseline interpreter r=iain
https://hg.mozilla.org/integration/autoland/rev/52306e2645c1
part 6 - Emit an entry trampoline for each script that enters the C++ interpreter r=iain

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0af592aed892
https://hg.mozilla.org/mozilla-central/rev/85831bb256a9
https://hg.mozilla.org/mozilla-central/rev/27dd48c17e15
https://hg.mozilla.org/mozilla-central/rev/5736319db66d
https://hg.mozilla.org/mozilla-central/rev/76fe7cc09a39
https://hg.mozilla.org/mozilla-central/rev/52306e2645c1