1815553 - [wmfme] Check EME option when enabling Media Foundation CDM

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[John Lin [:jhlin][:jolin]]

In bug 1810817, mfcdm is enabled even when EME is not, and it causes build failures.

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1815553 - move Media Foundation CDM option into EME support configurations.

Comment 2

[mac198442]

It also might be nice to fix it so that attempting to override the disable results in a configure failure saying that enabling mf-cdm with eme disabled is invalid. Otherwise you just end up with the failure linking xul.dll with an undefined refernece which give you no clue as to how to fix.

Comment 3

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1815553 - follow the naming convention of existing code (mf -> wmf). r=alwu

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2cfe3ce1eb1
follow the naming convention of existing code (mf -> wmf). r=alwu
https://hg.mozilla.org/integration/autoland/rev/789d292e1b47
move Media Foundation CDM option into EME support configurations. r=alwu,firefox-build-system-reviewers,ahochheiden

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing mbu failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/9efd7587d21c975950060ea0ac762994f2f60092

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3b9784c27fb
follow the naming convention of existing code (mf -> wmf). r=alwu

Comment 7

[Alastor Wu [:alwu]]

As the new try failures requires more time to fix and we wanted to fix other thunderbird bustage first, we land one of the patch and other patch from bug1816060. We still need to land another patch in order to fix the error completely (right now they use the workaround from bug 1815546) So keep this bug open until we land both patches.

Comment 8

[mac198442]

Just a thought here but Should not this line :
option("--disable-wmf-cdm", help="Disable support for Media Foundation CDM")
be changed to:
option("--disable-wmf-cdm", help="Disable support for Windows Media Foundation CDM")
?

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a3b9784c27fb

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc697f7862c5
move Media Foundation CDM option into EME support configurations. r=alwu,firefox-build-system-reviewers,ahochheiden

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fc697f7862c5

Comment 12

[John Lin [:jhlin][:jolin]]

Closing this bug for all patches were landed.