1815557 - Pseudo class toggles could make better use of available space

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Tim Nguyen :ntim]

Attachment: image.png

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1639052

:zacnomore, since you are the author of the regressor, bug 1639052, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

switching to a grid could work

diff --git a/devtools/client/themes/rules.css b/devtools/client/themes/rules.css
--- a/devtools/client/themes/rules.css
+++ b/devtools/client/themes/rules.css
@@ -60,7 +60,8 @@
 
 .ruleview-reveal-panel {
   border-bottom: 1px solid var(--theme-splitter-color);
-  display: flex;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(100px, max-content));
   overflow: hidden;
   flex-wrap: wrap;
   margin: 2px;
@@ -77,9 +78,6 @@
 
 .ruleview-reveal-panel label {
   user-select: none;
-  flex-grow: 1;
-  width: 30%;
-  min-width: 100px;
   display: flex;
   align-items: center;
 }

Comment 3

[Zac Svoboda :zacnomore]

Makes sense to me, thank you for checking this out. I'll get right on it.

Comment 4

[Zac Svoboda :zacnomore]

Attachment: Bug 1815557 - Improve space usage by pseudo class toggles r=nchevobbe

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1639052

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

This bug has the keyword regression, so its type should be defect.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:zacnomore, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

did the required change and pushed the patch

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/477f53b97730
Improve space usage by pseudo class toggles r=nchevobbe,devtools-reviewers

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/477f53b97730