1815565 - Set about:config pref `print.save_as_pdf.use_page_rule_size_as_paper_size.enabled` to `true` by default

Status: RESOLVED FIXED

(Core :: Printing: Output, task)

Description

[Daniel Holbert [:dholbert]]

[edited to fix a bug number copypasta typo]

Bug 1793220 is landing behind a defaulting-to-false pref, print.save_as_pdf.use_page_rule_size_as_paper_size.enabled, because it's got at least one known issue (bug 1815555).

I'm preemptively filing this bug on flipping the pref to true once we're ready (maybe just after bug 1815555 is fixed; though if any other blockers come up, we can track them as blocking this bug and wait on them as well if needed).

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)

I'm preemptively filing this bug on flipping the pref to true once we're ready (maybe just after bug 1815555 is fixed

bug 1815555 ended up being fixed up-front as part of Bug 1793220's patch.

So I think we can toggle this pref pretty soon (after Bug 1793220 lands and introduces the pref). Probably good to have a few days of Nightly testing with the pref off, though, so that we have some confidence that we can safely revert the pref-flip if we discover some breakage during the beta cycle, for example.

Comment 2

[Fred Chasen [:fchasen]]

Attachment: Bug 1815565 - Set pref print.save_as_pdf.use_page_rule_size_as_paper_size.enabled to true by default r?dholbert

Comment 3

[Daniel Holbert [:dholbert]]

I'd like for us to fix bug 1820651, which is kind of a version of this same functionality that doesn't work yet. But I don't think this pref-flip hurts anything there, and it's generally an improvement.

So: seems good. Thanks fchasen!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdb3eafe2455
Set pref print.save_as_pdf.use_page_rule_size_as_paper_size.enabled to true by default r=dholbert

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fdb3eafe2455