1815638 - Camera permission flow do not handle : `Ask Every Time` permission

Status: NEW

(Fenix :: General, defect, P2)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

From github: https://github.com/mozilla-mobile/fenix/issues/27177.

Steps to reproduce

1. On android 11 or later
2. Go the address bar
3. Use the scanner feature
4. When the permission prompt open select : Only this time
5. Close the application
6. Force it to stop (Long press on icon / Info / Force stop)
7. Reopen and select the scanner feature again

Expected behaviour

The permission prompt should open and allow to grant the permission.

Actual behaviour

Another dialog window open which prompt the user to grant the permission. It offers two actions : ignore or bring the user to the application settings.
But when going to the application settings the camera permission appear correctly as Ask every time.

Device name

Google Pixel 4a (5G) on CalyxOS

Android version

Android 12

Firefox release type

Firefox

Firefox version

105.1.0

Device logs

No response

Additional information

First some of the label I'm quoting might be wrong since I'm running in French on my phone sorry ^^.

As mentioned, I believe the Ask every time option appeared with Android 11 (Source)

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[Timshel]

Hey,

Related issue on the subject : 1814472
Opened PR with proposed fix : 27276

My latest comment on the subject :

First I want to mention that from an user point of view especially if he accepts there is almost no change to the UX. So merging this now would not be a case of changing an UX flow to modify it again one month later.

Additionally adding a rationale in this case is probably tricky since here the use case is quite clear : if you want to scan you need the camera; having the correct balance of informative but not to bothersome might take some time.

In the mean time, I believe the change I propose would be a better flow to work from :

• It fix the current bug
• Limit dependency to flags since it just rename an existing one and rely less on it which improve resiliency to outside change of permission.
• I did some additional test and the ``Ask every time` is already supported when using the webcam on a website so it would make things more coherent.

Thank you.

Comment 2

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1815638 - disable permission prompt pre checking (#822)

Comment 3

[Adina Petridean QA [:apetridean]]

Still reproducible on Firefox 112.0b1 with Samsung GalaxyZ Fold 4 (Android 13).

Comment 4

[Timshel]

Hey,
Just fixed the conflict on the PR and did a quick retesting and it looks good :).
Would be nice to see progress on this :).
Have a nice day.

Comment 5

[Timshel]

Hey,
If there is some interest I'm still around and can update the matching PR :)

Comment 6

[Jonathan Almeida [:jonalmeida]]

NI Mike who was pinged to review the patch. Could you take a look at it?

Comment 7

[Timshel]

Hey,

So the matching issue was closed today due to the migration to Mozilla central.
Is there any interest in me porting it ?

I believe Mozilla is in the progress of migrating to Git ? https://groups.google.com/a/mozilla.org/g/firefox-dev/c/QnfydsDj48o/m/8WadV0_dBQAJ
So should we expect another migration since you linked to the Mercurial repository ?

Comment 9

[Jack]

My description from bug 1888809:
User Agent: Mozilla/5.0 (Android 13; Mobile; rv:121.0) Gecko/121.0 Firefox/121.0

Steps to reproduce:

Try to read a QR code rather than enter URL

Actual results:
An error message appears:
'Camera access needed. Please go to Android settings, tap permissions and allow.'

Expected results:
Since permission is already set to 'Ask Every Time'
Firefox should ask permission to use camera, read the Qr code and then revoke temporary permission (perhaps after a delay to allow a 'untroubled retry' at the QR code)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

The Git migration, while in the works, is still a long ways off in practice. That said, there is supported tooling that allows developers to interact with our Mercurial repositories via Git right now.
https://firefox-source-docs.mozilla.org/mobile/android/geckoview/contributor/mc-quick-start.html

Sorry for the limbo your patch got caught up in with the repo migration, but if you're still willing to rebase it and submit for review, I'll try to help ensure that it gets looked at in a timely fashion.

Comment 11

[Timshel]

Hey

Just to be sure, when the original Issue/PR was open it end-up blocked due to an UX parent issue : https://bugzilla.mozilla.org/show_bug.cgi?id=1814472

Is it expected now that it could proceed ?