Closed Bug 1815639 Opened 2 years ago Closed 2 years ago

Make some delete handlers stop touching `Selection` directly

Categories

(Core :: DOM: Editor, task, P3)

Product:
Core
Component:
DOM: Editor
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(12 files)

Bug 1815639 - part 1: Make `HTMLEditor::DeleteTextAndTextNodesWithTransaction` stop touching `Selection` directly r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815639 - part 2: Make `WhiteSpaceVisibilityKeeper::DeleteInvisibleASCIIWhiteSpaces` stop touching `Selection` directly r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815639 - part 3: Make `WhiteSpaceVisibilityKeeper::MakeSureToKeepVisibleStateOfWhiteSpacesAroundDeletingRange` stop touching `Selection` directly r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815639 - part 4: Make `AutoDeleteRangesHandler::HandleDeleteAroundCollapsedRanges` stop touching `Selection` directly r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815639 - part 5: Make `WhiteSpaceVisibilityKeeper::ReplaceText` stop touching `Selection` directly r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815639 - part 6: Make `DeletePreviousWhiteSpace` and `DeleteInclusiveNextWhiteSpace` of `WhiteSpaceVisibilityKeeper` stop touching `Selection` directly r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815639 - part 7: Make `WhiteSpaceVisibilityKeeper::DeleteContentNodeAndJoinTextNodesAroundIt` stop touching `Selection` directly r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815639 - part 8: Make `HTMLEditor::InsertBRElementIfHardLineIsEmptyAndEndsWithBlockBoundary` stop touching `Selection` directly r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815639 - part 9: Make `AutoDeleteRangesHandler::HandleDeleteCollapsedSelectionAtWhiteSpaces` stop touching `Selection` directly r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815639 - part 10: Make `AutoDeleteRangesHandler::HandleDeleteCollapsedSelectionAtVisibleChar` stop touching `Selection` directly r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815639 - part 11: Make `AutoDeleteRangesHandler::HandleDeleteAtomicContent` stop touching `Selection` directly r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815639 - part 12: Make `AutoDeleteRangesHandler::HandleDeleteHRElement()` stop touching `Selection` r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/8058610fbfa2 part 1: Make `HTMLEditor::DeleteTextAndTextNodesWithTransaction` stop touching `Selection` directly r=m_kato
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/7128f92b0f44 part 2: Make `WhiteSpaceVisibilityKeeper::DeleteInvisibleASCIIWhiteSpaces` stop touching `Selection` directly r=m_kato
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/f258e1aa3aaa part 3: Make `WhiteSpaceVisibilityKeeper::MakeSureToKeepVisibleStateOfWhiteSpacesAroundDeletingRange` stop touching `Selection` directly r=m_kato
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/cbad6c18f117 part 4: Make `AutoDeleteRangesHandler::HandleDeleteAroundCollapsedRanges` stop touching `Selection` directly r=m_kato
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/2c4c2de47f0e part 5: Make `WhiteSpaceVisibilityKeeper::ReplaceText` stop touching `Selection` directly r=m_kato
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/bc06c5bde6dd part 6: Make `DeletePreviousWhiteSpace` and `DeleteInclusiveNextWhiteSpace` of `WhiteSpaceVisibilityKeeper` stop touching `Selection` directly r=m_kato
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/663d6ed8142e part 7: Make `WhiteSpaceVisibilityKeeper::DeleteContentNodeAndJoinTextNodesAroundIt` stop touching `Selection` directly r=m_kato
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/66c6087f1714 part 8: Make `HTMLEditor::InsertBRElementIfHardLineIsEmptyAndEndsWithBlockBoundary` stop touching `Selection` directly r=m_kato
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/1d0f6b646877 part 9: Make `AutoDeleteRangesHandler::HandleDeleteCollapsedSelectionAtWhiteSpaces` stop touching `Selection` directly r=m_kato
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/11f7a3cc43e2 part 10: Make `AutoDeleteRangesHandler::HandleDeleteCollapsedSelectionAtVisibleChar` stop touching `Selection` directly r=m_kato
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/e2d9e7b2ce5e part 11: Make `AutoDeleteRangesHandler::HandleDeleteAtomicContent` stop touching `Selection` directly r=m_kato
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/480824b0882d part 12: Make `AutoDeleteRangesHandler::HandleDeleteHRElement()` stop touching `Selection` r=m_kato

https://hg.mozilla.org/mozilla-central/rev/8058610fbfa2
https://hg.mozilla.org/mozilla-central/rev/7128f92b0f44

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: