Closed Bug 1815677 Opened 3 years ago Closed 2 years ago

Add a new UniqueString marker schema format type

Categories

(Core :: Gecko Profiler, enhancement, P3)

enhancement

Tracking

()

RESOLVED DUPLICATE of bug 1600093
Tracking Status
firefox111 --- affected

People

(Reporter: canova, Unassigned, Mentored)

References

Details

(Whiteboard: [fp])

Currently we only have String marker schema type that stores the strings inside the profiler marker payload directly. But we also have cases where we would like to store the payload fields inside the string table. For example ScreenshotMarker has a field that we store inside the string table.
Instead of putting a SpecialFrontendLocation{}, we can display it directly with the marker schema properly if we had a UniqueString format type. This

Mentor: canaltinova

(In reply to Nazım Can Altınova [:canova][:canaltinova on phabricator] from comment #0)

Currently we only have String marker schema type that stores the strings inside the profiler marker payload directly. But we also have cases where we would like to store the payload fields inside the string table.

Do you think it would be possible to store a small string table inside the marker schema instead of in the global string table, to ensure there are few digits in the string index, and the space saving is maximum?

Yeah, I think this would be beneficial. Indeed it's unlikely that we'll have the same strings in the current string table and in the markers values.

Closing this as a duplicate of Bug 1600093 looks like we filed this multiple times already :)

Status: NEW → RESOLVED
Closed: 2 years ago
Duplicate of bug: 1600093
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.