1815682 - Uncaught error not helpful when exception is not an `Error`

Status: RESOLVED FIXED

(Testing :: Mochitest, enhancement)

Description

[William Durand [:willdurand]]

Similar to Bug 1767042, when we get an uncaught error that is not an instance of Error in a mochitest, we see the following:

[task 2023-02-07T18:09:13.870Z] 18:09:13     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_activeScript.js | Uncaught exception in test - at (unknown module):undefined - [object Object]

This isn't super helpful.

I suggest we do what was done in Bug 1767042 so that we would see the following instead:

[task 2023-02-08T10:48:26.783Z] 10:48:26     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_activeScript.js | Uncaught exception in test bound test_activeScript_with_unified_extensions_panel - at (unknown module):undefined - {"operation":"remove","path":"C:\\Users\\task_167584728925416\\AppData\\Local\\Temp\\generated-extension-1.xpi","winLastError":5,"stack":"","fileName":"(unknown module)"}

In addition, since we have the task name available, it'd be good to add it otherwise we only see a message saying "exception in test" (or "in setup") but nothing else.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1815682 - Improve the output of uncaught exceptions. r?gbrown!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/990ac0beeec4
Improve the output of uncaught exceptions. r=gbrown

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/990ac0beeec4