1815695 - [wpt-sync] Sync PR 38417 - Fix AtEnd() in fallback eager declaration block parsing.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38417 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38417
Details from upstream follow.

Steinar H. Gunderson <[e-mail]> wrote:

Fix AtEnd() in fallback eager declaration block parsing.

When trying to parse a CSS declaration block lazily, and falling back
to eager parsing because we see a { in it, we would not actually end
parsing it properly; the } would not trigger AtEnd(). Beside performance
issues, this would cause the fallback behavior at missing semicolon
at the end of the block to become different. Fix by reading the {
when opening the parse, setting up the block stack properly.

Fixed: 1413840
Change-Id: Ibc165990f75f0ccf1f20415b3add07ca6cd5203b

Reviewed-on: https://chromium-review.googlesource.com/4232538
WPT-Export-Revision: 33bbfcd889e0795913ef1e3131f8902e6ba6c7b8

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6fe9bfdc2aea8f9f6112c94fcd4b525a439fab00

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f429bb785ee
[wpt PR 38417] - Fix AtEnd() in fallback eager declaration block parsing., a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1f429bb785ee