Closed
Bug 1815749
Opened 1 year ago
Closed 1 year ago
Make variant 2's list of resource types in the <summary> reflect the checked items within the <details>
Categories
(Firefox :: Migration, task, P2)
Firefox
Migration
Tracking
()
RESOLVED
FIXED
113 Branch
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: mconley, Assigned: nolan.ishii)
References
Details
Attachments
(1 file)
Rules:
- The top line of the <summary> should say "Import all available data" when all resource types are checked.
- The second line of the <summary> should have a list of the resource types. We'll need new strings for these (we'll also need instructions in the Fluent file to tell localizers that they're used in a list, and to case accordingly). We should then capitalize the first character of the first resource type using
toLocaleUpperCase
, and then concatenate these resource type strings usingIntl.ListFormat
. - When only some of the resource types are checked, the top line of the <summary> should say "Import selected data"
- When no resource types are checked, the top line of the summary should say "No data selected for import"
Reporter | ||
Updated•1 year ago
|
Assignee: nobody → nolan.ishii
Reporter | ||
Comment 1•1 year ago
|
||
The specification can be found here: https://www.figma.com/file/PcMkM0ZaSSy3zmS3CYGWNj/Handover---students?node-id=2%3A18140&t=XOn8C1QMT2imT9HW-4
Updated•1 year ago
|
Severity: -- → N/A
Priority: -- → P2
Assignee | ||
Comment 2•1 year ago
|
||
Updated•1 year ago
|
Attachment #9318450 -
Attachment description: WIP: Bug 1815749 Make variant 2's list of resource types in the <summary> reflect the checked items within the <details>. r=mconley → Bug 1815749 Make variant 2's list of resource types in the <summary> reflect the checked items within the <details>. r=mconley
Updated•1 year ago
|
Attachment #9318450 -
Attachment description: Bug 1815749 Make variant 2's list of resource types in the <summary> reflect the checked items within the <details>. r=mconley → WIP: Bug 1815749 Make variant 2's list of resource types in the <summary> reflect the checked items within the <details>. r=mconley
Updated•1 year ago
|
Attachment #9318450 -
Attachment description: WIP: Bug 1815749 Make variant 2's list of resource types in the <summary> reflect the checked items within the <details>. r=mconley → Bug 1815749 Make variant 2's list of resource types in the <summary> reflect the checked items within the <details>. r=mconley
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f2e7da158ee9 Make variant 2's list of resource types in the <summary> reflect the checked items within the <details>. r=mconley,fluent-reviewers,flod
Comment 4•1 year ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•