Closed Bug 1815754 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 38421 - Reland "VT: Remove containment requirement."

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38421 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38421
Details from upstream follow.

Khushal Sagar <khushalsagar@chromium.org> wrote:

Reland "VT: Remove containment requirement."

This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387.

This was reverted earlier to wait for CSSWG feedback. The resolution
aligns with the behaviour in this patch.

https://github.com/w3c/csswg-drafts/issues/8139

Original change's description:

Revert "VT: Remove containment requirement."

This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd.

Reason for revert: Decided against this feature for now.

Original change's description:

VT: Remove containment requirement.

This patch removes the containment requirement from view-transitions.

This is to align with proposed resolution
https://github.com/w3c/csswg-drafts/issues/7882

R=​khushalsagar@chromium.org, bokan@chromium.org

Fixed: 1409491
Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
Reviewed-by: David Bokan \<bokan@chromium.org>
Reviewed-by: Khushal Sagar \<khushalsagar@chromium.org>
Commit-Queue: Vladimir Levin \<vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1096187}

Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
Commit-Queue: Vladimir Levin \<vmpstr@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1096273}

Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105
Reviewed-on: https://chromium-review.googlesource.com/4233087
WPT-Export-Revision: ad29f5f823293629c4ddc8ebee5d0dfa026ee1a4

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 22 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS : 1
FAIL : 13
TIMEOUT: 8
ERROR : 3
NOTRUN : 13

Chrome

PASS : 7
FAIL : 10
TIMEOUT: 10
ERROR : 4
NOTRUN : 8

Safari

OK : 1
FAIL : 14
TIMEOUT: 8
ERROR : 3
NOTRUN : 13

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec1852682f74 [wpt PR 38421] - Reland "VT: Remove containment requirement.", a=testonly https://hg.mozilla.org/integration/autoland/rev/dd67c4f53236 [wpt PR 38421] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ec1852682f74
https://hg.mozilla.org/mozilla-central/rev/dd67c4f53236

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.