1815819 - Omnibox keywords can be activated in search mode

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Gregory Pappas [:gregp]]

Attachment: omnibox.png

Steps to reproduce:

1. Navigate to https://github.com/gregorypappas/onDeleteSuggestion
2. Download and unzip the extension
3. Navigate to about:debugging -> This Firefox -> Temporary Extensions
4. Select 'Load Extension' and install the unzipped extension from step 4
5. Type @google omni 123 in the address bar

Actual results:
The extension's keyword is activated and the extension receives events

Expected results:
The extension's keyword does not activate.

This isn't intended behavior, right? It feels very broken.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:adw, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Marco Bonardo [:mak]]

It's not expected indeed, in search mode the omnibox provider should not even run :(

Comment 4

[Yazan Al Macki [:yazan]]

Attachment: Bug 1815819 - Set omnibox provider isActive to false when on search mode. r?jteow

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0b29efee642
Set omnibox provider isActive to false when on search mode. r=jteow,urlbar-reviewers

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e0b29efee642

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-07-09 Nightly build on Windows 10 using the steps from Comment 0.
Verified as fixed on Firefox Nightly 130.0a1 on Windows 10, Ubuntu 22, macOS 14.