1815827 - Get rid of unused editor prefs whose use counters were added in bug 1745895

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

All use counters of the following prefs were added in bug 1745895. Finally, we don't get any users in beta/nightly channels. So, we can get rid of them.

• editor.css.default_length_unit
• editor.hr_element.allow_to_delete_from_following_line
• editor.initialize_element_before_connect
• editor.positioning.offset
• editor.resizing.preserve_ratio
• editor.use_div_for_default_newlines
• editor.truncate_user_pastes

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah, editor.truncate_user_pastes is a pref of experimental feature. Therefore, we should not delete it. Fortunately, removing it does not make the code so simpler.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1815827 - part 0: Delete unnecessary editor pref telemetry probes r=chutten!

Depends on D169758

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1815827 - part 1: Get rid of `editor.css.default_length_unit` pref r=m_kato!

Depends on D169759

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1815827 - part 2: Get rid of `editor.hr_element.allow_to_delete_from_following_line` pref r=m_kato!

Depends on D169760

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1815827 - part 3: Get rid of `editor.initialize_element_before_connect` pref r=m_kato!

Depends on D169761

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1815827 - part 4: Get rid of `editor.positioning.offset` pref r=m_kato!

Depends on D169762

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1815827 - part 5: Get rid of `editor.resizing.preserve_ratio` pref r=m_kato!

Depends on D169763

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1815827 - part 6: Get rid of `editor.use_div_for_default_newlines` pref r=m_kato!

Depends on D169764

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a38ad1a89a1
part 0: Delete unnecessary editor pref telemetry probes r=chutten
https://hg.mozilla.org/integration/autoland/rev/292a8be61c08
part 1: Get rid of `editor.css.default_length_unit` pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b76f7ce17480
part 2: Get rid of `editor.hr_element.allow_to_delete_from_following_line` pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/17cc9b89ab6d
part 3: Get rid of `editor.initialize_element_before_connect` pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b6f13993ed07
part 4: Get rid of `editor.positioning.offset` pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/355849e8d80f
part 5: Get rid of `editor.resizing.preserve_ratio` pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/366270298679
part 6: Get rid of `editor.use_div_for_default_newlines` pref r=m_kato

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/3a38ad1a89a1
https://hg.mozilla.org/mozilla-central/rev/292a8be61c08
https://hg.mozilla.org/mozilla-central/rev/b76f7ce17480
https://hg.mozilla.org/mozilla-central/rev/17cc9b89ab6d
https://hg.mozilla.org/mozilla-central/rev/b6f13993ed07
https://hg.mozilla.org/mozilla-central/rev/355849e8d80f
https://hg.mozilla.org/mozilla-central/rev/366270298679