Closed Bug 1815827 Opened 8 months ago Closed 7 months ago

Get rid of unused editor prefs whose use counters were added in bug 1745895

Categories

(Core :: DOM: Editor, enhancement, P3)

Product:
Core
Component:
DOM: Editor
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 2 open bugs)

Details

Attachments

(7 files)

Bug 1815827 - part 0: Delete unnecessary editor pref telemetry probes r=chutten!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815827 - part 1: Get rid of `editor.css.default_length_unit` pref r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815827 - part 2: Get rid of `editor.hr_element.allow_to_delete_from_following_line` pref r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815827 - part 3: Get rid of `editor.initialize_element_before_connect` pref r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815827 - part 4: Get rid of `editor.positioning.offset` pref r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815827 - part 5: Get rid of `editor.resizing.preserve_ratio` pref r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1815827 - part 6: Get rid of `editor.use_div_for_default_newlines` pref r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review

All use counters of the following prefs were added in bug 1745895. Finally, we don't get any users in beta/nightly channels. So, we can get rid of them.

  • editor.css.default_length_unit
  • editor.hr_element.allow_to_delete_from_following_line
  • editor.initialize_element_before_connect
  • editor.positioning.offset
  • editor.resizing.preserve_ratio
  • editor.use_div_for_default_newlines
  • editor.truncate_user_pastes

Ah, editor.truncate_user_pastes is a pref of experimental feature. Therefore, we should not delete it. Fortunately, removing it does not make the code so simpler.

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/3a38ad1a89a1
part 0: Delete unnecessary editor pref telemetry probes r=chutten
https://hg.mozilla.org/integration/autoland/rev/292a8be61c08
part 1: Get rid of `editor.css.default_length_unit` pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b76f7ce17480
part 2: Get rid of `editor.hr_element.allow_to_delete_from_following_line` pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/17cc9b89ab6d
part 3: Get rid of `editor.initialize_element_before_connect` pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b6f13993ed07
part 4: Get rid of `editor.positioning.offset` pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/355849e8d80f
part 5: Get rid of `editor.resizing.preserve_ratio` pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/366270298679
part 6: Get rid of `editor.use_div_for_default_newlines` pref r=m_kato
You need to log in before you can comment on or make changes to this bug.