1815843 - Buttons in permission panel are clipped if there are longer domain names

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Sören Hentzschel]

Attachment: screenshot

The buttons in the permissions panel are not fully visible if there are domain names that are a bit longer. It's a regression from bug 1799460.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1815843 - Allow cross-site cookie permissions to shrink. r=Gijs,dao,itiel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47da5c3c1655
Allow cross-site cookie permissions to shrink. r=Itiel

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/47da5c3c1655

Comment 5

[Pascal Chevrel:pascalc]

Emilio, that patch is minimal, should we uplift it in our 110 dot release? Thanks

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9316821 [details]
Bug 1815843 - Allow cross-site cookie permissions to shrink. r=Gijs,dao,itiel

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): very targeted css fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 111.0a1 (2023-02-09) on Windows 10x64 by using this test webpage.
The issue is verified fixed with Firefox 11.0b5 on Windows 10x64, macOS 12, and Ubuntu 20.04. The cross-site cookie permissions buttons are correctly displayed and no longer clipped when using the above webpage and granting permission to known-tracker.englehardt-tracker.com.

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9316821 [details]
Bug 1815843 - Allow cross-site cookie permissions to shrink. r=Gijs,dao,itiel

Low risk UI fix, uplift approved for 110.0.1, thanks!

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/91114b66e6f0

Comment 10

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixes with Firefox 110.0.1 (20230227191043) on Windows 10x64, macOS 12 and Ubuntu 20.04. The cross-site cookie permission panel is correctly displayed when having a long domain name like known-tracker.englehardt-tracker.com from this test webpage.