1815893 - Nightly Pref Sanitization Crashes

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[Tom Ritter [:tjr]]

This bug tracks the crashes we're seeing in Nightly after rolling out pref sanitization crashes there. We also rolled out sanitization (no crashes) in 111 which will ride out to beta and then release. We may get bug reports for that behavior (because we have some telemetry coming in we don't understand affecting a small number of users.)

Comment 1

[Tom Ritter [:tjr]]

As of this comment:

• 2 crashes (1 user) for network.protocol-handler.expose.magnet - this is a user-editing-a-pref mistake, these preferences should be bools not strings
• 18 crashes (1 user) for userChrome.searchSelectionShortcut.keycode - that's a userchrome thing and I let that community know here

Comment 2

[Tom Ritter [:tjr]]

10 more crashes:

• intl.hyphenation-alias.de-AT-1996
• intl.date_time.pattern_override.date_medium

Comment 3

[Tom Ritter [:tjr]]

Attachment: Bug 1815893: Allowlist two internationalization custom preferences

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fbd405d0347
Allowlist two internationalization custom preferences r=mccr8

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/8fbd405d0347

Comment 6

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1811294

Comment 7

[Tom Ritter [:tjr]]

No new crashes, so that's a good sign!

Comment 8

[Donal Meehan [:dmeehan]]

:tjr can this be resolved for now or do you still need the leave-open?

Comment 9

[Tom Ritter [:tjr]]

I'm still watching the crashes, so I want to keep it open for now to remind me.

Comment 10

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:KrisWright, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 11

[Tom Ritter [:tjr]]

I'll make it S2 because we are tracking this for release. As we get closer to release we can triple check things and close it out.

Comment 12

[Tom Ritter [:tjr]]

Okay, new crashes:

• network.protocol-handler.expose.magnet - Seems to be 2 different users, 1 crash each
• xpinstall.enabled - 6 crashes, all seem to be the same user, with one of them occurring after a reinstall. This is supposed to be a bool also

Comment 13

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

:tjr Is there anything to do here for 111? Marking as fix-optional for now.

Comment 14

[Tom Ritter [:tjr]]

Crashes are still very low and telemetry on release shows 24 distinct users affected since Jan 1. We don't know why those most of those events are coming in (e.g. Bug 1808783), but I did see three that were only affecting one person each (or maybe just one person) that we can safely add to the allowlist.

Comment 15

[Tom Ritter [:tjr]]

Attachment: Bug 1815893: Add three more preferences to the allowlist r?freddyb

Depends on D171763

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b345170401db
Add three more preferences to the allowlist r=freddyb

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b345170401db