1816131 - Improve about:logging styles

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Julien Wajsberg [:julienw]]

about:logging has some styling issues. I'd like to fix the most obvious ones in this bug.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: Bug 1816131 - Fix the shared style for normal select inputs so that they look like menulist entries r=itiel

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: Bug 1816131 - Improve the style and html of about:logging for output checkboxes and preset dropdown r=itiel

This uses the actual ids for the labels so that clicking the labels
actually work.
This also adds some flex magic so that the labels are aligned with their
checkboxes.
Finally this indents the file part so that the hierarchy is better seen.

Depends on D169485

Comment 3

[Julien Wajsberg [:julienw]]

Attachment: Bug 1816131 - Increase the indentations so that the hierarchy is more visible r=padenot

Depends on D169486

Comment 4

[Julien Wajsberg [:julienw]]

Attachment: Bug 1816131 - Avoid jumps when changing the presets in about:logging r=itiel

This aligns the panel to the left and also sets a max width.
This also changes the element that has "None" (because no MOZ_LOG entry
is set at that moment) to a div like when there are modules, so that it
doesn't jump down the first time the user selects a preset.

Depends on D169487

Comment 5

[Julien Wajsberg [:julienw]]

Attachment: Bug 1816131 - In about:logging, use <form> elements with their submit events rather than the click event r=sfoster

Then pressing enter in the input also triggers the change just like a
click on the button.

Depends on D169488

Comment 6

[Julien Wajsberg [:julienw]]

Attachment: Bug 1816131 - Improve the CSS and HTML of about:logging to make the CSS more resilient r=itiel

This is more in line with the rest of the styling in other about pages.

Depends on D169631

Comment 7

[Julien Wajsberg [:julienw]]

Attachment: Bug 1816131 - Apply a reformatter on the about:logging HTML markup r=itiel

Depends on D169631

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5889cd3bf9b7
Fix the shared style for normal select inputs so that they look like menulist entries r=Itiel,desktop-theme-reviewers
https://hg.mozilla.org/integration/autoland/rev/fcfe1d5d0311
Improve the style and html of about:logging for output checkboxes and preset dropdown r=Itiel
https://hg.mozilla.org/integration/autoland/rev/fb3d2e983f36
Improve the CSS and HTML of about:logging to make the CSS more resilient r=Itiel
https://hg.mozilla.org/integration/autoland/rev/2e29f043ecc9
Avoid jumps when changing the presets in about:logging r=Itiel
https://hg.mozilla.org/integration/autoland/rev/2ef4625d5d6d
In about:logging, use <form> elements with their submit events rather than the click event r=sfoster
https://hg.mozilla.org/integration/autoland/rev/32be81d9b0cd
Apply a reformatter on the about:logging HTML markup r=Itiel

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5889cd3bf9b7
https://hg.mozilla.org/mozilla-central/rev/fcfe1d5d0311
https://hg.mozilla.org/mozilla-central/rev/fb3d2e983f36
https://hg.mozilla.org/mozilla-central/rev/2e29f043ecc9
https://hg.mozilla.org/mozilla-central/rev/2ef4625d5d6d
https://hg.mozilla.org/mozilla-central/rev/32be81d9b0cd