1816149 - Early Hints in Firefox Profiler are broken.

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P3)

Description

[Manuel Bucher [:manuel]]

One thing could be that it's due to overwriting the channelId on connect back (this was for displaying the channel correctly in devtools, but that doesn't work either). And also showing the preload channel in the parent in the same line as the channel in the content process would be good.

Comment 1

[Manuel Bucher [:manuel]]

Maybe this has something to do with LOAD_REPLACE not being set in the EarlyHintPreloader channel: https://searchfox.org/mozilla-central/rev/aa3ccd258b64abfd4c5ce56c1f512bc7f65b844c/netwerk/base/nsIChannel.idl#239

Comment 2

[Manuel Bucher [:manuel]]

Attachment: Bug 1816149 - Fix Early Hints in the Firefox Profiler by not changing the channelId anymore r=#necko

The Firefox Profiler expects the channelId to not change. There is no
reason to change the channelId. It was a measure to associate the early
hint preload in devtools and profiler, but neither is the case right
now: Devtools currently don't show preloads at all and changing the
channelId messes up the profiler.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68c2210ea2eb
Fix Early Hints in the Firefox Profiler by not changing the channelId anymore r=necko-reviewers,jesup

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/68c2210ea2eb