1816182 - Stop applying ESLint test configuration to module files

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mark Banner (:standard8)]

When module files are in test directories, we apply the configurations to them regardless. This means that they can get the wrong globals applied.

I think we should therefore exclude them from the test configurations. There are some rules that may not get applied, but I think generally it is only mozilla/no-arbitrary-setTimeout and @microsoft/sdl/no-insecure-url that would not get applied, and I think that is reasonable for test module files.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1816182 - Remove unused BlocklistTestProxy. r?Gijs!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1816182 - Stop applying ESLint test configuration to module files. r?Gijs!

Depends on D169512

Comment 3

[:Gijs (he/him)]

bug 1675349 removed the one consumer of BlocklistTestProxy being removed here.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf1c189a9e28
Remove unused BlocklistTestProxy. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/69b339baa090
Stop applying ESLint test configuration to module files. r=Gijs,necko-reviewers

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bf1c189a9e28
https://hg.mozilla.org/mozilla-central/rev/69b339baa090