1816214 - on new win7 workers (at azure) work to enable more browser-chrome coverage of browser_startup* files

Status: RESOLVED FIXED

(Core :: Performance, task)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in https://phabricator.services.mozilla.com/D169523 we are disabling browser_startup.js and browser_startup_syncIPC.js on windows 7. I did a try push and you can see the IPC failure here:
https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=7c2064ae47033690f1eb91926cd42aa68bf55a43

once we are running on the new windows 7 hardware, we should find a way to disable a subset of these tests, and also revisit browser_startup.js.

to run on the new hardware right now before the migration, please do:
./mach try fuzzy -q 'test-windows7-32 browser-chrome' --worker-override='t-win7-32=releng-hardware/gecko-t-win7-32-hw'

of course you can optimize this a bit if you wish like:
./mach try fuzzy -q 'test-windows7-32 browser-chrome' --worker-override='t-win7-32=releng-hardware/gecko-t-win7-32-hw' browser/base/content/test/performance/io

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1816214 - allow PWebRenderBridge::Msg_EnsureConnected 3 times before first paint in browser_startup_syncIPC.js to make the test pass on win7 azure workers, r=jmaher.

Comment 2

[Florian Quèze [:florian]]

(In reply to Joel Maher ( :jmaher ) (UTC -8) from comment #0)

in https://phabricator.services.mozilla.com/D169523 we are disabling browser_startup.js and browser_startup_syncIPC.js on windows 7. I did a try push and you can see the IPC failure here:
https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=7c2064ae47033690f1eb91926cd42aa68bf55a43

Thanks for the try run!

browser_startup.js seems to pass here, I saw no failure for it. browser_startup_syncIPC.js fails consistently, but is easy to fix, I attached the trivial fix, that can either land separately, or be included in your patch for bug 1816191.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

if you can land it separately that would be great; then I can rebase and do a quick rerun; ideally enabling both tests.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c8fa31115c9
allow PWebRenderBridge::Msg_EnsureConnected 3 times before first paint in browser_startup_syncIPC.js to make the test pass on win7 azure workers, r=jmaher.

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5c8fa31115c9

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 9317199 [details]
Bug 1816214 - allow PWebRenderBridge::Msg_EnsureConnected 3 times before first paint in browser_startup_syncIPC.js to make the test pass on win7 azure workers, r=jmaher.

Beta/Release Uplift Approval Request

• User impact if declined: n/a
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1816191
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): we need to move the windows7 workers from aws -> azure, this change is necessary to keep the tests green.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9317199 [details]
Bug 1816214 - allow PWebRenderBridge::Msg_EnsureConnected 3 times before first paint in browser_startup_syncIPC.js to make the test pass on win7 azure workers, r=jmaher.

:jmaher I'll reject the beta uplift approval, 111 is now in beta. The patch landed in central before 111 merged to beta.
Leaving the release uplift request as is, unless you confirm it's not needed in the release branch?

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

oh, thanks for noticing that; this will be needed in release; so leave it for release approval

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9317199 [details]
Bug 1816214 - allow PWebRenderBridge::Msg_EnsureConnected 3 times before first paint in browser_startup_syncIPC.js to make the test pass on win7 azure workers, r=jmaher.

Approved for 110.0.1.