1816338 - Investigate the reason why scroll-target-snap-002.html fails

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

Though the test fails on all browsers, we should know the reason.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Differences between scroll-target-snap-002.html and scroll-target-snap-003.html

I believe the failure is a correct behavior, I mean the test itself has a mistake.

There's a similar test, scroll-target-snap-003.html, a main difference between the failed test and this test is that this test uses Element.focus() rather than Element.scrollIntoView. So both tests should behave in the same manner in terms of scrolling. But there's another difference which, I believe, makes scroll-target-snap-002.html fails. The difference is the target element position. You can see the difference in the file I am attaching.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1816338 - Move scrollIntoView's target element above a ".foildn" element. r?#layout-reviewers

With the change, the DOM tree structures match scroll-target-snap-003.html
which passes on all browsers.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a5bd0d08ed2
Move scrollIntoView's target element above a ".foildn" element. r=emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38476 for changes under testing/web-platform/tests

Comment 5

[Marian-Vasile Laza]

Backed out changeset 0a5bd0d08ed2 (Bug 1816338) for wr failures on scroll-target-snap-002.html.
Backout link
Push with failures Wr3
Failure Log

Comment 6

[Hiroyuki Ikezoe (:hiro)]

I forgot re-adding the ini file (when I pushed a try run I removed it to see unexpected-pass on the try run).

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c9f9c654b5a
Backed out changeset 0a5bd0d08ed2 for wr failures on scroll-target-snap-002.html.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e74d14d3a7df
Move scrollIntoView's target element above a ".foildn" element. r=emilio

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e74d14d3a7df

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot