Open Bug 1816403 Opened 2 years ago Updated 2 years ago

Swift: Move global HttpPingUploader state into a singleton

Categories

(Data Platform and Tools :: Glean: SDK, task, P4)

Product:
Data Platform and Tools
Component:
Glean: SDK
Type:
task

Tracking

(Not tracked)

People

(Reporter: janerik, Unassigned)

Details

(Whiteboard: [telemetry:glean-rs:backlog])

We keep some state about the uploader process in a global variable, modified by 2 global functions.
That's not too bad.
But we could consider moving this into the HttpPingUploader class itself and create a singleton.

There's not necessarily a major upside to this. This basically just moves where the global state is. It might make it a bit more obvious at the call site.

We also currently keep creating new instances of HttpPingUploader.
This is unnecessary (though it makes testing easier).

Priority: P3 → P4
Whiteboard: [telemetry:glean-rs:m?] → [telemetry:glean-rs:backlog]
You need to log in before you can comment on or make changes to this bug.