1816429 - Crash in [@ gfxFcPlatformFontList::InitSharedFontListForPlatform::$::operator()]

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Gabriele Svelto [:gsvelto]]

Crash report: https://crash-stats.mozilla.org/report/index/42d606f1-8db1-4f32-99e6-47afe0230211

Reason: SIGSEGV / SEGV_MAPERR

Top 10 frames of crashing thread:

0  libxul.so  gfxFcPlatformFontList::InitSharedFontListForPlatform const  gfx/thebes/gfxFcPlatformFontList.cpp:1837
1  libxul.so  gfxFcPlatformFontList::InitSharedFontListForPlatform  gfx/thebes/gfxFcPlatformFontList.cpp:1885
2  libxul.so  gfxPlatformFontList::InitFontList  gfx/thebes/gfxPlatformFontList.cpp:578
3  libxul.so  gfxPlatformFontList::Initialize  gfx/thebes/gfxPlatformFontList.cpp:266
4  libxul.so  gfxPlatform::Init  gfx/thebes/gfxPlatform.cpp:978
5  libxul.so  gfxPlatform::GetPlatform  gfx/thebes/gfxPlatform.cpp:463
6  libxul.so  gfxPlatform::InitializeCMS  gfx/thebes/gfxPlatform.cpp:2111
7  libxul.so  gfxPlatform::EnsureCMSInitialized  gfx/thebes/gfxPlatform.h:964
7  libxul.so  gfxPlatform::GetCMSMode  gfx/thebes/gfxPlatform.h:519
7  libxul.so  nsXPLookAndFeel::GetUncachedColor  widget/nsXPLookAndFeel.cpp:1008

Not 100% sure this is the right component but anyway... This is a startup crash hitting a NULL pointer returned by calls to FcConfigGetFonts(). Reading the documentation and peeking into the codebase it doesn't seem like FcConfigGetFonts() guarantees that it returns a non-NULL pointer so maybe we should just add NULL checks here? Or missing fonts would break rendering? Reading the comments I have the feeling that this is happening because the user was in the middle of a system upgrade and some files "disappeared" under Firefox.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

gfxFcPlatformFontList::AddFontSetFamilies() checks !aFontSet but addFontSetFamilies doesn't so looks like we're missing it.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1816429 Check aFontSet in addFontSetFamilies() r?emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84ecdd1962c8
Check aFontSet in addFontSetFamilies() r=emilio

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/84ecdd1962c8

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9317325 [details]
Bug 1816429 Check aFontSet in addFontSetFamilies() r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: possible crashes while font processing
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): null pointer check
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9317325 [details]
Bug 1816429 Check aFontSet in addFontSetFamilies() r?emilio

Approved for 111.0b2

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/118a646a4fa2