1816440 - `./mach try ... --artifact` should imply `--disable-pgo`

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[[e-mail] (:bhearsum)]

Currently, ./mach try ... --artifact only affects non-shippable (aka PGO) builds. This is fine for many use cases, but there are a number of tasks that depend exclusively on shippable builds, and it's when testing those types of tasks it usually doesn't matter if you have a full build, or whether or not it's PGO. --disable-pgo partly does this: it disables the profile run and instrumented build parts of shippable builds. When combined with --artifact, you end up with a single, artifact build - exactly what we want!

We should make this the default behaviour for --artifact. It's very surprising behaviour to pass --artifact and end up with a full, 2 stage build because you happen to be testing something that needs a shippable build.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: Bug 1816440: ./mach try ... --artifact should imply --disable-pgo r?#releng-reviewers!

Currently, ./mach try ... --artifact only affects non-shippable (aka PGO) builds. This is fine for many use cases, but there are a number of tasks that depend exclusively on shippable builds, and it's when testing those types of tasks it usually doesn't matter if you have a full build, or whether or not it's PGO. --disable-pgo partly does this: it disables the profile run and instrumented build parts of shippable builds. When combined with --artifact, you end up with a single, artifact build - exactly what we want!

We should make this the default behaviour for --artifact. It's very surprising behaviour to pass --artifact and end up with a full, 2 stage build because you happen to be testing something that needs a shippable build.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f853b488db5d
/mach try ... --artifact should imply --disable-pgo r=releng-reviewers,jcristau

Comment 3

[[e-mail] (:bhearsum)]

Attachment: Bug 1816440: bustage fix for test failure r?#releng-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/073d6070b7cf
bustage fix for test failure. r=jcristau

Comment 5

[[e-mail] (:bhearsum)]

Attachment: Bug 1816440: bustage fix #2 for test failure r?#releng-reviewers!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b5c8d6892fb
bustage fix #2 for test failure. r=jcristau

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for causing try related failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f853b488db5df0594948a685d382a67643348f95&selectedTaskRun=UHyFddbvTMWj815yCnklgg.0

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=405447099&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=405447077&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/046e3d52f7a96c643f6128873e9a727b10bcb617

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44b9f814ccd4
/mach try ... --artifact should imply --disable-pgo r=releng-reviewers,jcristau

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/44b9f814ccd4