1816472 - Try to remove setters for individual window size / position properties.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Emilio Cobos Álvarez [:emilio]]

They are problematic as described in bug 1803611.

Content can't do this already, so it seems it should be feasible to remove this by replacing screenX setters by moveTo(<foo>, screenY) etc.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: WIP: Bug 1816472 - Diagnostic - crash on setting window coords.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1816472 - Make individual size / position properties really readonly. r=smaug,matc

They are problematic as described in bug 1803611.

Content can't do this already, so it seems it should be feasible to
remove this by replacing screenX setters by moveTo(<foo>, screenY) etc.

I'm running a diagnostic patch through try already (see the other patch
attached to the bug), and will fix tests / code as needed in separate
patches, but this can get its own stamp.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1816472 - Fix tests to avoid using readonly property setters. r=matc,smaug

Comment 4

[matc]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #0)

Content can't do this already,

Can't content currently do this whenever nsGlobalWindowOuter::CanMoveResizeWindows returns true?

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Err, I guess you're right. That said other browsers do follow the spec and make this readonly, so I think this should be safe.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00e6c8164834
Make individual size / position properties really readonly. r=smaug
https://hg.mozilla.org/integration/autoland/rev/e8f2fed41bd1
Fix tests to avoid using readonly property setters. r=smaug

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3963969666d1
Fix some tests that I missed because they're skipped on Linux.

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/00e6c8164834
https://hg.mozilla.org/mozilla-central/rev/e8f2fed41bd1
https://hg.mozilla.org/mozilla-central/rev/3963969666d1