1816500 - Enable CTAP2 support in early beta

Status: VERIFIED FIXED

(Core :: DOM: Web Authentication, enhancement, P1)

Description

[John Schanck [:jschanck]]

The last of the bugs blocking Bug 1814487 were fixed in the Firefox 111 nightly cycle. It would be useful to try enabling CTAP2 support in early Firefox 111 betas.

Comment 1

[John Schanck [:jschanck]]

Attachment: Bug 1816500 - enable CTAP2 support in early beta. r=dveditz

Comment 2

[John Schanck [:jschanck]]

Comment on attachment 9317438 [details]
Bug 1816500 - enable CTAP2 support in early beta. r=dveditz

Beta/Release Uplift Approval Request

• User impact if declined: Not having the opportunity to test in beta 111 will push the release of this feature out by a cycle.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): There are no known issues with flipping this pref. We didn't flip it before the merge because we were waiting for confirmation that Bug 1814722 was fixed. We have that confirmation now.
• String changes made/needed:
• Is Android affected?: No

Comment 3

[Donal Meehan [:dmeehan]]

:jschanck we can take this uplift after it's landed in central. I see the patch was reviewed and ready to land, anything blocking this?

Comment 4

[John Schanck [:jschanck]]

Thanks! I've queued it for landing.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e2435a2bfb8
enable CTAP2 support in early beta. r=dveditz

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7e2435a2bfb8

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9317438 [details]
Bug 1816500 - enable CTAP2 support in early beta. r=dveditz

Approved for 111.0b2

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1b006f33fac0

Comment 9

[Camelia Badau [:cbadau], Desktop Test Engineering]

Hello! Noticed in Comment 2, that Manual QA is needed for verifying this. Is it enough to check that the "security.webauthn.ctap2" pref is set to true in early beta or do we need to test something specific here?
Thank you!

Comment 10

[John Schanck [:jschanck]]

Yes, it's enough to check that the pref is set to true in early beta. Thank you!

Comment 11

[Mihai Boldan, Desktop QA [:mboldan]]

I confirm that the "security.webauthn.ctap2" pref is set to true on Firefox 112.0a1 (2023-02-20) and on Firefox 111.0b3.
Tests were performed under Windows 10x64, macOS 10.15 and under Ubunut 16.04x64.