Closed Bug 1816571 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 38481 - Add css image-set gradient images parsing tests

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38481 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38481
Details from upstream follow.

Traian Captan <tcaptan@chromium.org> wrote:

Add css image-set gradient images parsing tests

Current parsing tests cover only \<linear-gradient()> and
\<radial-gradient()>.

Based on the image-set spec, all gradient image values are supported,
and they should also be tested.

This change adds image-set gradient images parsing tests for

  • \<repeating-linear-gradient()>
  • \<repeating-radial-gradient()>
  • \<conic-gradient()>
  • \<repeating-conic-gradient()>

Spec definitions:
[1]
"The syntax for image-set() is:
\<image-set()> = image-set( \<image-set-option># )
\<image-set-option> = [ \<image> | \<string> ]
[ \<resolution> || type(\<string>) ]"

[2]
"\<image> = \<url> | \<image()> | \<image-set()> | \<cross-fade()> |
\<element()> | \<gradient>"

[3]
"\<gradient> = [
\<linear-gradient()> | \<repeating-linear-gradient()> |
\<radial-gradient()> | \<repeating-radial-gradient()> |
\<conic-gradient()> | \<repeating-conic-gradient()> ]"

[1] https://w3c.github.io/csswg-drafts/css-images-4/#image-set-notation
[2] https://w3c.github.io/csswg-drafts/css-images-4/#image-values
[3] https://w3c.github.io/csswg-drafts/css-images-4/#typedef-gradient

R=pdr

Bug: 1400902
Change-Id: Ie1460a5c93c1184ae9d5537e0e24ee2b47d68135
Reviewed-on: https://chromium-review.googlesource.com/4247618
WPT-Export-Revision: 5810dc56f1397d1f39ea1dd7f108baa747aec726

PR 38481 applied with additional changes from upstream: 0c713b20204b355c0bd91f0333cdb685f90411b7
Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3dc60841bcff [wpt PR 38481] - Add css image-set gradient images parsing tests, a=testonly
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66b75a295125 [wpt PR 38481] - Add css image-set gradient images parsing tests, a=testonly

https://hg.mozilla.org/mozilla-central/rev/66b75a295125

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9022d12a19b6 [wpt PR 38481] - Add css image-set gradient images parsing tests, a=testonly
Test result changes from PR not available.
You need to log in before you can comment on or make changes to this bug.