1816664 - Rename addSessionData/removeSessionData methods of RootMessageHandler to addSessionDataItem/removeSessionDataItem

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P3)

Description

[Alexandra Borovova [:Sasha]]

Follow up from the discussion here: https://phabricator.services.mozilla.com/D169420#inline-936951

Since now in https://searchfox.org/mozilla-central/source/remote/shared/messagehandler/RootMessageHandler.sys.mjs we have method updateSessionData, which updates multiple SessionData items at once, it makes sense to update addSessionData/removeSessionData methods to addSessionDataItem/removeSessionDataItem since they work only with one SessionData item at a time.

Comment 1

[ntshangase]

Hello, I'm an Outreachy applicant (in the contributing phase), Can I be assigned this bug.

Comment 2

[ofrazy]

Attachment: Bug 1816664 Rename addSessionData/removeSessionData methods of RootMessageHandler to addSessionDataItem/removeSessionDataItem

Comment 3

[Alexandra Borovova [:Sasha]]

(In reply to ntshangase from comment #1)

Hello, I'm an Outreachy applicant (in the contributing phase), Can I be assigned this bug.

Hi! Unfortunately, looks like it's already taken, ofrazy attached the patch.
So hopefully you will something else to work on!

Comment 4

[ofrazy]

Attachment: Bug 1816664 Rename addSessionData/removeSessionData methods of RootMessageHandler to addSessionDataItem/removeSessionDataItem Differential Revision: https://phabricator.services.mozilla.com/D172513

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62a6d7cc6645
Rename addSessionData/removeSessionData methods of RootMessageHandler to addSessionDataItem/removeSessionDataItem r=webdriver-reviewers,Sasha

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/62a6d7cc6645