1816740 - PFilePicker cleanup and modernization

Status: RESOLVED FIXED

(Core :: Widget: Win32, task)

Description

[Ray Kraesig [:rkraesig]]

The FilePicker IPC protocol could use a bit of cleanup and modernization.

(This is for some largely uninteresting work already done in support of 1677170.)

Comment 1

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1816740 [1/6] - convert CRLF to LF in recent IPDL files r?handyman

Some recently-created IPDL files have CRLFs rather than LFs. Convert
these.

No functional changes.

Comment 2

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1816740 [3/6] - convert nsIFilePicker::result* into a proper enum r?#ipc-reviewers,karlt,mstange,handyman

Convert the various result* constants in nsIFilePicker into a proper
enum, and perform validation when passing it across IPC.

Depends on D169851

Comment 3

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1816740 [4/6] - convert nsIFilePicker::mode* into a proper enum r?#ipc-reviewers,karlt,mstange,handyman

Convert the various mode* constants in nsIFilePicker into a proper
enum, and perform validation when passing it across IPC.

Depends on D169852

Comment 4

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1816740 [5/6] - convert nsIFilePicker::capture* to a proper enum r?#ipc-reviewers,karlt,mstange,handyman

Convert the various capture* constants in nsIFilePicker into a proper
enum, and perform validation when passing it across IPC.

Additionally, unlike the previous two enums, reduce the size of
CaptureTarget to 8 bits. This is a workaround for its use with
nsAttrValue, which at present very specifically requires that parseable
enums' values fit within an int16_t -- and a uint16_t does not.

Depends on D169853

Comment 5

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1816740 [6/6] - remove ManualDealloc from ColorPicker and FilePicker r?#ipc-reviewers

The existing manual-deallocation code isn't actually doing anything
interesting. Strip it out.

(No functional changes.)

Depends on D169854

Comment 6

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1816740 [2/6] - move Windows geolocation actor to subdirectory r?handyman

In the interest of keeping directory sizes down to a manageable level,
pull the new Windows utility-process geolocation code into its own
directory. (This is not yet an issue, but will become so as new
utility-process functionality is added.)

No functional changes.

Depends on D169851

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f61a5d87ceca
[1/6] - convert CRLF to LF in recent IPDL files  r=handyman
https://hg.mozilla.org/integration/autoland/rev/2bbd544567af
[2/6] - move Windows geolocation actor to subdirectory  r=handyman
https://hg.mozilla.org/integration/autoland/rev/eda1bfa85458
[3/6] - convert nsIFilePicker::result* into a proper enum  r=ipc-reviewers,karlt,mstange,handyman,nika
https://hg.mozilla.org/integration/autoland/rev/1255c0424d56
[4/6] - convert nsIFilePicker::mode* into a proper enum  r=ipc-reviewers,karlt,mstange,handyman,nika
https://hg.mozilla.org/integration/autoland/rev/9c14c8be846a
[5/6] - convert nsIFilePicker::capture* to a proper enum  r=ipc-reviewers,karlt,mstange,handyman,nika
https://hg.mozilla.org/integration/autoland/rev/dab075577d74
[6/6] - remove ManualDealloc from ColorPicker and FilePicker  r=ipc-reviewers,nika

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f61a5d87ceca
https://hg.mozilla.org/mozilla-central/rev/2bbd544567af
https://hg.mozilla.org/mozilla-central/rev/eda1bfa85458
https://hg.mozilla.org/mozilla-central/rev/1255c0424d56
https://hg.mozilla.org/mozilla-central/rev/9c14c8be846a
https://hg.mozilla.org/mozilla-central/rev/dab075577d74

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d10338c86a5e
Port Bug 1816740 - Convert nsIFilePicker::result* into a proper enum. rs=bustage-fix