Closed Bug 1816925 Opened 1 year ago Closed 6 months ago

Implement SendOrder for WebTransportSendStreams

Categories

(Core :: Networking: HTTP, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
119 Branch
Tracking Status
firefox119 --- fixed

People

(Reporter: jesup, Assigned: jesup, NeedInfo)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, Whiteboard: [necko-triaged])

Attachments

(1 file)

We don't currently implement SendOrder for outgoing streams. We'll need to accept it on creation, and pipe it through IPC to the protocol API when creating a stream. This may requite protocol API changes, and perhaps internal implementation changes in the protocol to prioritize by sendorder.

Severity: -- → S3
Priority: -- → P2
Whiteboard: [necko-triaged]
Assignee: nobody → edgul

Noting WIP doc if anyone wants to pick this up while I've backburnered my work on it.
Sorry for the google doc.
https://docs.google.com/document/d/1tyLBdFguyqTUuxom3Yo3IHXIlFDAmz_F2ZtWkvPi5Gw/edit#heading=h.lp6n8jdjm4e7

Assignee: edgul → nobody
Duplicate of this bug: 1821672

Note: the neqo implementation of this does not currently provide 'fairness'
between streams at the same priority

Assignee: nobody → rjesup
Status: NEW → ASSIGNED

MDN docs note - support for this accidentally added to BCD. Now removed in https://github.com/mdn/browser-compat-data/pull/19983 but will need to be re-added when this completes (added dev-doc-needed).

Keywords: dev-doc-needed
Depends on: 1836897
Depends on: 1850870
Attachment #9334916 - Attachment description: Bug 1816925: Implement WebTransport SendOrder r=kershaw → Bug 1816925: Implement WebTransport SendOrder r=kershaw!
Attachment #9334916 - Attachment description: Bug 1816925: Implement WebTransport SendOrder r=kershaw! → Bug 1816925: Implement WebTransport SendOrder at the DOM level r=kershaw!
Pushed by rjesup@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd2b009cdee4
Implement WebTransport SendOrder at the DOM level r=kershaw,necko-reviewers

Backed out for causing bustage on Http3Session.cpp

[task 2023-08-31T18:21:39.255Z] 18:21:39     INFO -  In file included from Unified_cpp_protocol_http1.cpp:119:
[task 2023-08-31T18:21:39.255Z] 18:21:39    ERROR -  /builds/worker/checkouts/gecko/netwerk/protocol/http/Http3Session.cpp:2487:14: error: unused variable 'rv' [-Werror,-Wunused-variable]
[task 2023-08-31T18:21:39.255Z] 18:21:39     INFO -      nsresult rv = mHttp3Connection->WebTransportSetSendOrder(
[task 2023-08-31T18:21:39.255Z] 18:21:39     INFO -               ^
[task 2023-08-31T18:21:39.255Z] 18:21:39     INFO -  1 error generated.
[task 2023-08-31T18:21:39.256Z] 18:21:39    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:660: Unified_cpp_protocol_http1.o] Error 1
Flags: needinfo?(rjesup)
Pushed by rjesup@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0410a9861503
Implement WebTransport SendOrder at the DOM level r=kershaw,necko-reviewers
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
Regressions: 1851192

FF119 MDN Docs work for this tracked in https://github.com/mdn/content/issues/29300.

You need to log in before you can comment on or make changes to this bug.