1816957 - Expose CryptoKey on Workers and enable lots of WPT tests

Status: RESOLVED FIXED

(Core :: DOM: Web Crypto, task, P3)

Description

[Christoph Kerschbaumer [:ckerschb]]

It seems we are failing lots of WebCryptoAPI web platform tests because CryptoKey is not exposed to workers.

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1816957: Expose CryptoKey on Workers and enable lots of WPT tests, r=keeler

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Hey @krosylight, thanks for reviewing the *webidl changed within D169945.

I pushed the changes to TRY and realized that test dom/serviceworkers/test/test_serviceworker_interfaces.html started failing.

The error is:

FAIL undefined: If this is failing: DANGER, are you sure you want to expose the new interface CryptoKey to all webpages as a property on self? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)

Do you know what I have to do? I suppose I have to register that interface somehwere for the test, but couldn't find out where. Or is there something else I need to do?

Thank you!

Comment 3

[Kagami Rosylight [:saschanaz] (they/them) (OOO until Dec 11)]

• https://searchfox.org/mozilla-central/source/dom/workers/test/test_worker_interfaces.js
• https://searchfox.org/mozilla-central/source/dom/serviceworkers/test/test_serviceworker_interfaces.js

Please update those two files. I also added the comment to Phabricator. Sorry for the confusion!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37d1ee9374e0
Expose CryptoKey on Workers and enable lots of WPT tests, r=keeler,webidl,saschanaz

Comment 5

[Marian-Vasile Laza]

Backed out changeset 37d1ee9374e0 (Bug 1816957) for wpt failures on idlharness.https.any.worker.html.
Backout link
Push with failures <--> wpt9
Failure Log

Comment 6

[Kagami Rosylight [:saschanaz] (they/them) (OOO until Dec 11)]

Oops. You'll probably want to choose all WPT in ./mach try chooser as ./mach try does not always pick all of them.

Comment 7

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Marian-Vasile Laza from comment #5)

Backed out changeset 37d1ee9374e0 (Bug 1816957) for wpt failures on idlharness.https.any.worker.html.

Rrr. I'll take a look. Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4df58e165c4e
Expose CryptoKey on Workers and enable lots of WPT tests, r=keeler,webidl,saschanaz

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4df58e165c4e