Closed Bug 1816980 Opened 2 years ago Closed 2 years ago

Implement the default CFR doorhanger copy and delay and remove the experiment code

Categories

(Core :: Privacy: Anti-Tracking, enhancement)

Product:
Core
Component:
Privacy: Anti-Tracking
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: jhirsch, Assigned: dwalker)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-cookie-banner-v2])

Attachments

(1 file)

Bug 1816980 - remove copy experiment code and implement finalize copy. r?#fluent-reviewers,#omc-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Note: we have canceled the CFR onboarding experiment for 111. Instead, we await instructions from product on what onboarding doorhanger copy and delay to set to default. Moving into the v1.5 metabug, as we intend to land this for Firefox 112.

Original description:
In 111 / v1, we are shipping three copy/timing variations for the CFR onboarding doorhanger. Once we have a winning variation, we'll want to remove the others in tree, and update the CFR-related code from experiment code to rollout code.

Whiteboard: [fidefe-cookie-banner-v2]
Blocks: 1819995
No longer blocks: 1801680
Summary: Rollout prep: choose the winning CFR variation and remove others → Implement the default CFR doorhanger copy and delay and remove the experiment code
Assignee: nobody → dwalker
Status: NEW → ASSIGNED
Pushed by dwalker@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eed7574265d1 remove copy experiment code and implement finalize copy. r=fluent-reviewers,omc-reviewers,flod,aminomancer

Backed out for causing bc failures on browser_sma_enable_cbh.js.

[task 2023-03-09T20:47:44.948Z] 20:47:44     INFO - TEST-START | toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_enable_cbh.js
[task 2023-03-09T20:47:44.963Z] 20:47:44     INFO - GECKO(11930) | [Child 12121: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7fdca3840400 == 1 [pid = 12121] [id = 1] [url = about:newtab]
[task 2023-03-09T20:47:44.968Z] 20:47:44     INFO - GECKO(11930) | [Child 12105: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f00f3928400 == 1 [pid = 12105] [id = 0]
[task 2023-03-09T20:47:44.968Z] 20:47:44     INFO - GECKO(11930) | [Child 12105: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (7f00f8c94470) [pid = 12105] [serial = 1] [outer = 0]
[task 2023-03-09T20:47:44.969Z] 20:47:44     INFO - GECKO(11930) | [Child 12105: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (7f00f3928c00) [pid = 12105] [serial = 2] [outer = 7f00f8c94470]
[task 2023-03-09T20:47:45.167Z] 20:47:45     INFO - GECKO(11930) | [Child 12121: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (7fdca296a270) [pid = 12121] [serial = 4] [outer = 0] [url = about:newtab]
[task 2023-03-09T20:47:45.232Z] 20:47:45     INFO - GECKO(11930) | [Child 12105: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (7f00f392b800) [pid = 12105] [serial = 3] [outer = 7f00f8c94470]
[task 2023-03-09T20:47:45.433Z] 20:47:45     INFO - TEST-INFO | started process screentopng
[task 2023-03-09T20:47:45.635Z] 20:47:45     INFO - TEST-INFO | screentopng: exit 0
[task 2023-03-09T20:47:45.635Z] 20:47:45     INFO - Buffered messages logged at 20:47:44
[task 2023-03-09T20:47:45.635Z] 20:47:45     INFO - Entering test bound test_enable_cbh
[task 2023-03-09T20:47:45.636Z] 20:47:45     INFO - Buffered messages logged at 20:47:45
[task 2023-03-09T20:47:45.637Z] 20:47:45     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "https://example.com/" line: 0}]
[task 2023-03-09T20:47:45.637Z] 20:47:45     INFO - Buffered messages finished
[task 2023-03-09T20:47:45.638Z] 20:47:45     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_enable_cbh.js | Uncaught exception in test bound test_enable_cbh - at resource://messaging-system/lib/SpecialMessageActions.jsm:403 - Error: Special message action with type ENABLE_CBH is unsupported.
[task 2023-03-09T20:47:45.638Z] 20:47:45     INFO - Stack trace:
[task 2023-03-09T20:47:45.638Z] 20:47:45     INFO - handleAction@resource://messaging-system/lib/SpecialMessageActions.jsm:403:15
[task 2023-03-09T20:47:45.639Z] 20:47:45     INFO - test_enable_cbh@chrome://mochitests/content/browser/toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_enable_cbh.js:20:31
[task 2023-03-09T20:47:45.640Z] 20:47:45     INFO - Leaving test bound test_enable_cbh
[task 2023-03-09T20:47:45.763Z] 20:47:45     INFO - GECKO(11930) | MEMORY STAT | vsize 11394MB | residentFast 489MB | heapAllocated 228MB
[task 2023-03-09T20:47:45.765Z] 20:47:45     INFO - TEST-OK | toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_enable_cbh.js | took 815ms
[task 2023-03-09T20:47:45.769Z] 20:47:45     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-03-09T20:47:45.772Z] 20:47:45     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_enable_cbh.js | Found an unexpected tab at the end of test run: https://example.com/ - 
[task 2023-03-09T20:47:45.808Z] 20:47:45     INFO - GECKO(11930) | [Child 12019: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7fa483528000 == 4 [pid = 12019] [id = 7]
[task 2023-03-09T20:47:45.808Z] 20:47:45     INFO - GECKO(11930) | [Child 12019: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 14 (7fa46cd883f0) [pid = 12019] [serial = 18] [outer = 0]
[task 2023-03-09T20:47:45.810Z] 20:47:45     INFO - GECKO(11930) | [Child 12019: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 15 (7fa466e89400) [pid = 12019] [serial = 19] [outer = 7fa46cd883f0]
[task 2023-03-09T20:47:45.841Z] 20:47:45     INFO - checking window state
[task 2023-03-09T20:47:45.899Z] 20:47:45     INFO - TEST-START | toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_handle_multiaction.js
Flags: needinfo?(dwalker)
Pushed by dwalker@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/241855066121 remove copy experiment code and implement finalize copy. r=fluent-reviewers,omc-reviewers,flod,aminomancer
Flags: needinfo?(dwalker)

https://hg.mozilla.org/mozilla-central/rev/241855066121

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: