1816998 - Read macOS attribution data from Mozilla-specific extended attribute

Status: RESOLVED FIXED

(Firefox :: Installer, enhancement, P3)

Description

[Nick Alexander :nalexander [he/him]]

This ticket tracks reading macOS attribution data from a Mozilla-specific extended attribute of the main Firefox.app bundle at runtime.

We might choose to cache this data to keep it consistent across a profile's lifetime.

The existing implementation is in practice obsolete, so I don't think we need to guard the new implementation behind a Gecko preference or bother with a rollout.

This work is all in and around https://searchfox.org/mozilla-central/source/browser/components/attribution.

Comment 1

[[e-mail] (:bhearsum)]

For posterity, I've been told that the data review we did for Windows attribution in https://bugzilla.mozilla.org/show_bug.cgi?id=1515172 is valid for our work on macOS as well, so I will not be filing a data review request here.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: Bug 1816998: Replace macOS quarantine database-based attribution with extended attribute attribution r?nalexander!

With extended attribute attribution using exactly the same attribution strings as Windows (eg: no URLs), this turns out to be quite straightforward. Once we've pulled in the attribution string from the extended attribute, the existing parsing, validation, etc. just works.

The only wrinkle is that the extended attributes may have nul bytes or tabs that we need to strip away. (Tabs may be present because we use them to pad the attribution area when we prepare the DMG for attribution. Nul bytes may be present because we overwrite the entire attribution before updating the attribution data.)

Comment 3

[[e-mail] (:bhearsum)]

Attachment: Bug 1816998: Update ASRouter to use extended attribute attribution on macOS r?pdahiya!

Depends on D189258

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c937eafeffe2
Replace macOS quarantine database-based attribution with extended attribute attribution r=nalexander
https://hg.mozilla.org/integration/autoland/rev/f06103d86424
Update ASRouter to use extended attribute attribution on macOS r=pdahiya

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c937eafeffe2
https://hg.mozilla.org/mozilla-central/rev/f06103d86424