1817096 - Intermittent failure in RTCPeerConnection-getStats.https.html related to inbound-rtp stats

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P3)

Description

[Byron Campen [:bwc]]

This test has not been running for some time due to a timeout in a preceding test-case, but it seems to be flaky for some reason.

Comment 1

[Byron Campen [:bwc]]

After some experimentation, it seems that this is the culprit:

https://searchfox.org/mozilla-central/rev/dbec4165e4c26a0ff970b614842b689e8357593c/dom/media/webrtc/transportbridge/MediaPipeline.cpp#588,600

Here we are invoking the callback that triggers unmute before passing the packet on to libwebrtc. I think that in some situations, the unmute event arrives in JS, and JS can turn around and call getStats, before the RTP packet is queued up for libwebrtc. Making the call to OnRtpPacketReceived after we send the packet to libwebrtc seems to make this test-case work reliably.

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1817096: Queue up unmute events after passing RTP to libwebrtc. r?pehrsons

Depends on D172615

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1817096: Bring the blocking of unmute events in line with the spec. r?mjf

Depends on D172615

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 1817096: Drive unmute from the conduit (on call thread) instead of the pipeline (on STS). r?pehrsons

Depends on D172906

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=0c80700271c3f642abdd2a4522b9f8e3748a995e
https://treeherder.mozilla.org/jobs?repo=try&revision=c5559e6daf9d94abc17462292f7af21a04b646be
https://treeherder.mozilla.org/jobs?repo=try&revision=b1dd66282e5e405e6fb3835eb5ebb2e361b6652c

Comment 6

[Byron Campen [:bwc]]

Try looks ok:

https://treeherder.mozilla.org/jobs?repo=try&revision=410973785e05375edc2f9a5fa0df241dc7976b19
https://treeherder.mozilla.org/jobs?repo=try&revision=97ad4e5640cd8187d6a74f2ac0e9a1693031a1de

Comment 7

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=ca6445eba0a080536b32727228f6240539a09f44
https://treeherder.mozilla.org/jobs?repo=try&revision=8e3d446f84172596dea3c55c60c3c719cbcf98b9

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d678f5ba6a3
Bring the blocking of unmute events in line with the spec. r=mjf
https://hg.mozilla.org/integration/autoland/rev/b89b9564bb4b
Drive unmute from the conduit (on call thread) instead of the pipeline (on STS). r=pehrsons

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39260 for changes under testing/web-platform/tests

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3d678f5ba6a3
https://hg.mozilla.org/mozilla-central/rev/b89b9564bb4b

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot