1817176 - Partial Test For `URL::SetPort(const nsAString& aPort)` When `NS_FAILED(rv)`

Status: RESOLVED FIXED

(Core :: DOM: Networking, enhancement, P3)

Description

[Carolin Brandt]

Attachment: test.html

---

This report is part of a research collaboration between Mozilla and the TU Delft.
If you want to help us understand whether this report is helpful,
please answer a few questions before you start addressing the report.

If you would rather talk to us or show your process on screen, you can schedule a call (write Carolin at [e-mail]) or upload a screen recording.

---

We created a test case that executes the not-yet-tested code block at https://searchfox.org/mozilla-central/source/dom/url/URL.cpp#315.
However, the test is missing a functional check (is(..) or ok(..)) to check that the behavior of the code block is correct.

Please complete the test and add it to the test suite, if you think it is worth to do so.

In the attachments we provide the generated test (test.html).
It reaches the targeted code block through the stacktrace in stacktrace.txt.
We also provide some additional generated tests that target the same location (alternative_test_N.html).

Comment 1

[Carolin Brandt]

Attachment: stacktrace.txt

The line number for URL.cpp is a bit off, as the file changed since we collected this stacktrace.

Comment 2

[Carolin Brandt]

Attachment: alternative_test_1.html

Comment 3

[Carolin Brandt]

Attachment: alternative_test_2.html

Comment 4

[Carolin Brandt]

Attachment: alternative_test_3.html

Comment 5

[Valentin Gosu [:valentin] (he/him) {{ FYI: OOO 14 June - 4 August }}]

Attachment: Bug 1817176 - Add test for setting port to something that doesn't parse as a number r=#necko

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79f6624bf44c
Add test for setting port to something that doesn't parse as a number r=necko-reviewers,kershaw

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38620 for changes under testing/web-platform/tests

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/79f6624bf44c

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot