1817182 - Avoid re-exporting AccountState from sync's utils.sys.mjs

Status: RESOLVED FIXED

(Firefox :: Sync, task)

Description

[Mark Banner (:standard8)]

re-exports AccountState.

However, that seems to be from the days when it had to be accessed via the backstage pass.

I think it would be simpler to import AccountState where it is actually used, especially as this is test-only.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1817182 - Avoid re-exporting AccountState from sync's utils.sys.mjs. r?markh!

Depends on D170059

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62fe2f589efe
Avoid re-exporting AccountState from sync's utils.sys.mjs. r=markh

Comment 3

[Cristian Tuns]

Backed out for causing dt failures in browser_jsterm_autocomplete_null.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_null.js | Got error "ReferenceError: URI is not defined init resource://services-settings/remote-settings.sys.mjs:579 RemoteSettingsInit resource:///modules/BrowserGlue.sys.mjs:2963 _scheduleBestEffortUserIdleTasks resource:///modules/BrowserGlue.sys.mjs:3018 ChromeUtils::IdleDispatch handler*_scheduleBestEffortUserIdleTasks resource:///mo

Comment 4

[Mark Banner (:standard8)]

Well, that's a shame, we could have probably avoided all of these being backed out if I'd been asked first. Will re-land the unaffected patches.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/345598ecdf13
Avoid re-exporting AccountState from sync's utils.sys.mjs. r=markh

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/345598ecdf13