1817201 - CBH preferences checkbox should toggle the PBM mode pref as well as the regular mode pref

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

When the user toggles the about:preferences checkbox, we should toggle cookiebanners.service.mode.privateBrowsing as well as cookiebanners.service.mode.

This should be straightforward to implement:

• update writeCookieBannerMode in browser/components/preferences/privacy.js to set the private browsing mode to the same value that we're setting for the regular mode.
• update the test_checkbox_modifies_prefs test inside browser/components/preferences/tests/browser_privacy_cookieBannerHandling.js to also check the value of the cookiebanners.service.mode.privateBrowsing pref before and after checking the checkbox, as well as adding the default value for that pref to the pushPrefEnv setup call at the start of the test.
• we'll also need to notify QA to update their test cases to verify CBH is toggled in private browsing mode based on toggling the checkbox.

Comment 1

[DJ (:dwalker)]

Attachment: Bug 1817201 - sync PBM service.mode pref with base service.mode pref on settings page. r?#settings-reviewers

Comment 2

[DJ (:dwalker)]

Just adding a tiny piece of context here for clarity - the reason this bug exists is because we do not want to expose a separate pref control for CBH in private browsing mode, but under the hood we're looking for a different pref when in PBM for controlling the cookie banner handling behavior.

Comment 3

[DJ (:dwalker)]

[Tracking Requested - why for this release]:

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d17ba6893e2
sync PBM service.mode pref with base service.mode pref on settings page. r=settings-reviewers,Gijs

Comment 5

[DJ (:dwalker)]

Comment on attachment 9318252 [details]
Bug 1817201 - sync PBM service.mode pref with base service.mode pref on settings page. r?#settings-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Those enrolled in the cookie banner handling experiment as well as users foxfooding CBH may see inconsistent banner handling behavior between standard and private browsing modes
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:

1. Navigate to about:preferences#privacy
2. Scroll down to "cookie banner reduction"
3. Check (or uncheck) "Reduce Cookie Banners"
4. in about:config, verify that the checkbox correctly toggles both cookiebanners.service.mode and cookiebanners.service.mode.privateBrowsing to the same value (0=unchecked, 1=checked)

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fixes a minor bug for an unreleased feature
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6d17ba6893e2

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9318252 [details]
Bug 1817201 - sync PBM service.mode pref with base service.mode pref on settings page. r?#settings-reviewers

Approved for 111.0b3

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2814908f92ff

Comment 9

[Patriciu Pop [:ppop], Ecosystem QA]

I've verified that this issue is no longer reproducible, both service.mode prefs are toggled after enabling the feature from the about:preferences page. Tested using Firefox Nightly Version 112.0a1, Build ID 20230220165121 and Firefox Beta Version 111.0b3, Build ID 20230219190218 on Windows 10 x64, macOS 12.5 and Ubuntu 22.04 x64.