1817307 - Minimized PiP window is not movable

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Ania]

STRs:

1. Navigate to any video website, launch a video in PiP window.
2. Reduce the size of the PiP window to under 200px width or so.
3. Try to move the PiP window.

Expected result
PiP video can be freely moved around the screen.

Actual result

1. PiP video can't be moved unless you make it larger.

The issue is only reproducible with media.videocontrols.picture-in-picture.improved-video-controls.enabled pref set to true.

Comment 1

[kpatenio]

I looked into the issue and found that the gradient that we display for the bottom controls is the culprit here. We can't drag the window from the bottom. For testing, I removed the gradient styling and was able to move the window without issue. Adding -moz-window-dragging: drag; to the bottom gradient should do the trick.

Comment 2

[kpatenio]

Attachment: Bug 1817307 - make sure PiP is moveable when hovering over bottom controls gradient

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d78ccb81c5a2
make sure PiP is moveable when hovering over bottom controls gradient r=pip-reviewers,mhowell

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d78ccb81c5a2

Comment 5

[Daniel Bodea [:danibodea]]

I can reproduce this issue about the same in all OSes (Windows 10, MacOS 11, Ubuntu 22):

• In Beta v111.0b3, when the user launches the PiP, resizes to a about 320:180 he will notice that he cannot click to grab from areas: (1) at the left of the PLAY button, (2) between the PLAY and MUTE buttons, at the right of the MUTE buttons or under the PLAY and MUTE buttons. It can, however be moved if grabed from anywhere in the top halp of the PiP.
• If PiP is reduced even furhter to about 160:90 (half) the PiP is completely unmovable.

I can confirm that the bahavior is improved, but not completely fixed:

• In Nightly v112.0a1, when the user launches the PiP, resizes to a about 320:180 he will observe that the PiP is movable in all expected situations.
• If PiP is reduced even furhter to about 160:90 (half) The PiP can be grabed from the left of the PLAY button, the right of the MUTE button, but could NOT be grabbed from between the BACK TO TAB and CLOSE buttons. SOme inactive space can be observed around the BACK TO TAB and CLOSE buttons.

Furthermore, on MacOS, the PiP small resize limit should be implemented considering it can be resized to a much too small version, causing buttons to spill out.

Please let us know how you prefer to address this: reopen/log another issue/ignore. Thank you!

Comment 6

[kpatenio]

Thanks for testing the fix Daniel. Let's refer to a new bug.

Update: I filed a new bug https://bugzilla.mozilla.org/show_bug.cgi?id=1818064, for I already have a fix in mind and will submit a patch soon. Please update any other ticket details as you see fit.

I think I found why it occurs - the wrapping element for the scrubber is set as not movable, and we don't hide that element for smaller window sizes. We only set the actual scrubber that is wrapped as display:none. The one part that cannot be dragged is where the scrubber would've been positioned if visible.

Comment 7

[Daniel Bodea [:danibodea]]

This fix has been confirmed on Mac OS 11, Ubuntu 22 and Windows 10 in Beta v112.0b5.