1817381 - Inspector tooltip not scaled with rest of the UI

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Kristian Polso]

Attachment: Screenshot_20230217_083241.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

• Open "Inspector"
• Click on any HTML code in "Inspector"

Actual results:

The black tooltip that gets rendered in the viewport, is tiny (i.e. does not take into account UI scaling variables)

Expected results:

The tooltip should be of consistent size with other UI elements

Comment 1

[Kristian Polso]

Results from mozregression

 4:54.09 INFO: Narrowed integration regression window from [cb7c4d0b, d62480e6] (3 builds) to [cb7c4d0b, 6e1cbabc] (2 builds) (~1 steps left)
 4:54.09 INFO: No more integration revisions, bisection finished.
 4:54.09 INFO: Last good revision: cb7c4d0b946209a2a3b05cd5a35e31fadaf55135
 4:54.09 INFO: First bad revision: 6e1cbabce0af992a8ff5158959ac9dd69bea23a7
 4:54.09 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cb7c4d0b946209a2a3b05cd5a35e31fadaf55135&tochange=6e1cbabce0af992a8ff5158959ac9dd69bea23a7

Comment 2

[Kristian Polso]

I am running KDE 5.27, using display scaling of 250%. This worked perfectly in KDE 5.26, so might be something KDE related.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Inspector' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Setting Regressed by field after analyzing regression range found by mozregression in comment #1.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Can you attach about:support information? in particular, is this on X11 or wayland? I use KDE 5.27 on wayland (with 200% scaling rather than 250%) and it looks fine here.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Hah, nevermind, I do see this on X11 :)

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1817381 - Ignore OS zoom in devtools. r=nchevobbe

What devtools wants to do is ignoring the website-specific zoom.

It seems KDE 5.27 on X11 uses the text scale factor to implement scaling
of GTK apps completely (including Firefox), rather than the global
integer GTK scaling combined with it.

This makes this difference way more obvious than it otherwise would.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1817381 - Fix MousePosTracker in presence of OS text scale. r=dao,Gijs

In the past screenX etc didn't return CSS pixels properly, but now they
do and have for a while. Also the full zoom value of browser.xhtml is
always one, so this is only broken if we have OS text scale.

Depends on D170195

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1817381 - Remove DOMWindowUtils.fullZoom. r=jfkthame,#layout

Callers just want the actual full zoom, not the one including the OS
text-scale.

Android doesn't have OS zoom to begin with, so this can't change
behavior, but the desktop caller passes the usual full zoom here1, so
we're making the behavior match.

Depends on D170196

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1773342

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57479bbe7cd8
Fix MousePosTracker in presence of OS text scale. r=Gijs

Comment 12

[Emilio Cobos Álvarez [:emilio]]

After these patches the scrollbars still look tiny but that's a bug on KDE I believe, other GTK apps are also affected.

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/57479bbe7cd8

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d6e541704c3
Ignore OS zoom in devtools. r=devtools-reviewers,nchevobbe

Comment 15

[Cristina Horotan [:chorotan]]

Backed out changeset 9d6e541704c3 (bug 1817381) for causing multiple dt failures at: browser_toolbox_zoom_popup.js, browser_aboutdebugging_devtoolstoolbox_zoom.js

Backout: https://hg.mozilla.org/integration/autoland/rev/c2205ef935b8ad68ef2657caf9e4f1671c559895

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=9d6e541704c3bc4788efe47df7851638b5149499&selectedTaskRun=bqVxTWx2SUSxKAtgSKAe7w.0

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=406233683&repo=autoland&lineNumber=12804
https://treeherder.mozilla.org/logviewer?job_id=406233763&repo=autoland&lineNumber=2917

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/142a874fb54a
Ignore OS zoom in devtools. r=devtools-reviewers,nchevobbe

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/142a874fb54a

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/343daddee430
Remove DOMWindowUtils.fullZoom. r=jfkthame,layout-reviewers,extension-reviewers,rpl,geckoview-reviewers,m_kato

Comment 19

[Marian-Vasile Laza]

Backed out changeset 343daddee430 (Bug 1817381) for mochitest failures on test_bug574663.html.
Backout link
Push with failures <--> 13
Failure Log

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaf2d377bba7
Remove DOMWindowUtils.fullZoom. r=jfkthame,layout-reviewers,extension-reviewers,rpl,geckoview-reviewers,m_kato

Comment 21

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/aaf2d377bba7

Comment 22

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.

Comment 23

[Emilio Cobos Álvarez [:emilio]]

I don't think this is worth uplifting specially since KDE fixed it on their end too.

Comment 24

[Virgil Sangerean]

Reproduced on Firefox 111.0.

Issue is validated fixed on 112.0b9 Firefox.