1817525 - Voice input replaces your query instead of appending it

Status: VERIFIED FIXED

(Fenix :: Search, defect, P1)

Description

[Verdi [:verdi] Best to slack me]

Attachment: voice input.mp4

Steps to reproduce

1. Tap into the address bar and type the first part of a search query
2. Use voice input to complete your query

Expected behavior

The voice input appends what you've already typed

Actual behavior

The voice input replaces what you've already typed with what you've spoken

Device information

• Firefox version: 110.0.1
• Android device model: Samsung Galaxy S9
• Android OS version: 10

Any additional information?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1817525 - Voice input now appends query in EditToolbar (#1147)

Comment 3

[BMO Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/3b682607aedcd60eb3edb6afefcaefeb53cafa8d
Bug 1817525 - Voice input now appends query in EditToolbar

Comment 4

[Lorand Janos]

Verified on the latest Nightly 113.0a1 (2023-03-14).
Device used: Google Pixel 7 (Android 13).
Marking the ticket as Verified Fixed.

Comment 5

[Chris Peterson [:cpeterson]]

Rahul, do you think this bug fix would be safe to uplift to Beta 112? Or do you think it needs more Nightly "bake time" and should ride the trains in 113?

Comment 6

[Rahul Sainani [:rsainani]]

:cpeterson I think this could use a bit more "bake time" and ride the train in 113.