1817610 - Enable permissions-policy (aka feature-policy) support for midi

Status: NEW

(Core :: DOM: Device Interfaces, task)

Description

[Tom S]

The permissions-policy "midi" is inside the sExperimentalFeatures array, so we don't support it unless the pref dom.security.featurePolicy.experimental.enabled is set.
Considering that we are shipping midi support now we might want to change that as well.

I also found out that we made this change before while trying to enable WebMIDI in Bug 1752906 : https://hg.mozilla.org/mozilla-central/rev/465b1479681088abb02b311a207435d621ec1985

Comment 1

[Tom Schuster]

Attachment: Bug 1817610 - Use the Feature-Policy (Permissions-Policy) exclusively for denying MIDI access. r?jgraham

Comment 2

[James Graham [:jgraham]]

So I think testharness.js is just broken here? It seems like we can get duplicate messages when we try to backfill missed messages. I've made a change to avoid reprocessing dupes (although I feel like there's a better solution than that): https://treeherder.mozilla.org/jobs?repo=try&revision=ac8c81873f4b97ea31ecf34b6c3327af4cce8c8e

Comment 3

[James Graham [:jgraham]]

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=aaPDB_u1S96OSxY5PWROSQ.0&revision=ac8c81873f4b97ea31ecf34b6c3327af4cce8c8e suggests my attempt to fix this is pretty broken.

If you want a quick workaround here, one option is to avoid using fetch_tests_from_window but, since things are unsandboxed and same-origin just have the child window directly use parent.promise_test and so on for other other APIs so that you're just creating the tests in the top frame.

Comment 4

[Tom Schuster]

Thank you for looking into this. I will try to use the workaround, but this isn't very urgent.

Comment 5

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.