1817639 - Add an option to disable the simplified `prefers-reduced-motion` highlighters

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Description

[Julian Descottes [:jdescottes]]

From https://discourse.mozilla.org/t/how-to-change-box-highliter-in-developer-edition/111313/2

We should allow users to opt-out of the simplified highlighters added in Bug 1734195. Not all users who set prefers-reduced-motion to reduce necessarily want to have simplified highlighters.

We should add an option in the the DevTools settings panel, potentially only displayed when prefers-reduced-motion is enabled since it has no impact for users who don't rely on this.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1817639 - [devtools] Dynamically apply changes to the simplified highlighters preference

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1817639 - [devtools] Add setting for simple highlighters

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1817639 - [devtools] Use abortController to relay target actor events in highlighters.js

Depends on D170293

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1817639 - [devtools] Add toolbox notification about the simple highlighters setting

Depends on D170291

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1a24eacdf19
[devtools] Add setting for simple highlighters r=nchevobbe,devtools-reviewers,bolsson
https://hg.mozilla.org/integration/autoland/rev/a3e50060ba6b
[devtools] Use abortController to relay target actor events in highlighters.js r=nchevobbe,devtools-reviewers
https://hg.mozilla.org/integration/autoland/rev/c90fda7e795f
[devtools] Dynamically apply changes to the simplified highlighters preference r=nchevobbe,devtools-reviewers
https://hg.mozilla.org/integration/autoland/rev/8e1673c94b6c
[devtools] Add toolbox notification about the simple highlighters setting r=nchevobbe,fluent-reviewers,devtools-reviewers,flod

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a1a24eacdf19
https://hg.mozilla.org/mozilla-central/rev/a3e50060ba6b
https://hg.mozilla.org/mozilla-central/rev/c90fda7e795f
https://hg.mozilla.org/mozilla-central/rev/8e1673c94b6c

Comment 7

[Richard Marti (:Paenglab)]

Attachment: Bug 1817639 - [devtools] Add the pref devtools.inspector.simple-highlighters-reduced-motion to TB. r=mkmelin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/635ea67aa27d
[devtools] Add the pref devtools.inspector.simple-highlighters-reduced-motion to TB. r=mkmelin

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)