1817785 - Unable to change the month in the Datepicker panel if there already is a date set

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: datepicker1.mp4

Found in

• Nightly 112.0a1 (2023-02-20)

Affected versions

• Beta 111.0b3
• Release 110

Affected platforms

• ALL

Steps to reproduce

1. Reach data:text/html,<input type='datetime-local'>
2. Open the Datepicker from the Calendar button and select any date.
3. Reopen the Calendar button and use the arrow keys up or down in order to reach a different month.
4. Use tab to reach the Top Arrows and select them using space in order to change the month.

Expected result

• The Month from the calendar panel should change using the Arrows at the top of the Calendar or when using the keyboard arrows.

Actual result

• Unable to change the months if the user already selected a date.

Regression range
15:07.80 INFO: Last good revision: ecda109fed990c5e8a581ef1d5992bb63a5be749
15:07.80 INFO: First bad revision: 672458dd68513bedba20944a5b4c30e99d0f641e
15:07.80 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ecda109fed990c5e8a581ef1d5992bb63a5be749&tochange=672458dd68513bedba20944a5b4c30e99d0f641e

Comment 1

[Rares Doghi, Desktop QA]

Hi Anna, it seems that Bug 1806823 is whats causing this issue, can you please take a look ?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:ayeddi, since you are the author of the regressor, bug 1806823, could you take a look?

For more information, please visit auto_nag documentation.

Comment 3

[Anna Yeddi [:ayeddi]]

Attachment: 1817785-test-case.html

Adding a test case

Comment 4

[Anna Yeddi [:ayeddi]]

I tried to poke around but couldn't find an apparent issue, so I will work on this bug when I'm back from the leave

Comment 5

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1817785 - Updating a logic for a DateTimePanel's change of selection message. r=Jamie,emilio,kcochrane

As we want to keep communicating to the parent that the date picker is changed even when a calendar is updated without any new selection, but we want to keep the current selection and the input value until the user changes the selection, the new flag would communicate to the parent that there is no need to update a selection for a date picker on <input type=datetime-local> and <input type=date>. In the future it will be possible to be used by a time picker on <input type=time> as well, if needed.

TODO: Add tests

Comment 6

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1817785 - Update browser_datetime_datepicker test to have extra fail-proof checks. r?Jamie,emilio,kcochrane

With the Next/Prev button keyboard navigation being fixed in the previous patch (D177550), running datepicker tests with --verify discovered an intermittent toolkit/content/tests/browser/datetime/browser_datetime_datepicker.js failure likely due to the fast speed of the picker re-rendering while machine tested that took minor improvements to have extra state checks to resolve it.

Depends on D177550

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05dde90fd243
Updating a logic for a DateTimePanel's change of selection message. r=Jamie,emilio,kcochrane,mconley
https://hg.mozilla.org/integration/autoland/rev/76d6593441da
Update browser_datetime_datepicker test to have extra fail-proof checks. r=Jamie,emilio,kcochrane

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/05dde90fd243
https://hg.mozilla.org/mozilla-central/rev/76d6593441da

Comment 9

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build 115.0a1 (2023-05-21). I will update the flags for beta and release.

Comment 10

[Rares Doghi, Desktop QA]

Updating the main status flag.