1817794 - Consider removing the firefox view feature pref

Status: RESOLVED FIXED

(Firefox :: Firefox View, task, P3)

Description

[:Gijs (he/him)]

I don't think we're going to continue experimenting with turning view on/off as a whole, so I think we should probably just remove support for browser.tabs.firefox-view and the associated nimbus variable etc. ?

Comment 1

[Mike Kaply [:mkaply]]

I agree, but I think people were using this to turn off view.

Do we do something about that or just give them view back?

Comment 2

[:Gijs (he/him)]

(In reply to Mike Kaply [:mkaply] from comment #1)

I agree, but I think people were using this to turn off view.

Do we do something about that or just give them view back?

I think we have telemetry for the pref, right? Unless it's more than like 10k people, I think we do nothing - they can use the context menu to remove the item like everyone else (that group is orders of magnitude bigger than even 10k, and I would be astonished if 10k people turned this off using the hidden pref - ie if we make sure we disregard people who got the holdback experiment). Does that sound reasonable?

Comment 3

[Mike Kaply [:mkaply]]

Yes, sounds reasonable. We'll take a look.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sfoster, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1817794 - Remove Firefox View feature pref r=#fxview-reviewers

As we are no longer experimenting with turning this pref on and off and have moved to the newer
implementation of Firefox View, this pref has been removed.

We may want to notify users who prefer this feature hidden.

Depends on D196208

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7c11549e896
Remove Firefox View feature pref r=fxview-reviewers,sclements

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c7c11549e896