Closed Bug 1817818 Opened 2 years ago Closed 2 years ago

Create a shared module to generate HAR files from WebDriver BiDi events

Categories

(Remote Protocol :: WebDriver BiDi, task, P1)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task
Points:
2

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webdriver:m6])

We want to share the code used to generate HAR files so that fixes can be quickly communicated to everyone trying out HAR file generation with BiDi at the moment.

Typically, that would be integrated in our prototype client, in browsertime's branch, in our selenium branch...

The goal here will be to create a git repo to host this code.

Repository created with initial module + tests at https://github.com/juliandescottes/bidi-har-export

(In reply to Julian Descottes [:jdescottes] from comment #1)

Repository created with initial module + tests at https://github.com/juliandescottes/bidi-har-export

Hi Julian. This looks fine and great to see such a test coverage! For now I have only some minor comments:

  1. Remove the .DS_Store file and add an exception to .gitignore for it.
  2. the example from the readme uses a evt argument for recordEvent(). Maybe it can be more explicit what it is?
  3. An example to showcase how the Selenium adapter works would be good to have as well.
  4. For the Selenium adapter the driver has the browser name and version as part of the capabilities so there is no need to hard-code their values.

Feel free to apply or ignore. Do you plan to move to the Firefox DevTools org before closing this bug?

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #3)

(In reply to Julian Descottes [:jdescottes] from comment #1)

Repository created with initial module + tests at https://github.com/juliandescottes/bidi-har-export

Hi Julian. This looks fine and great to see such a test coverage! For now I have only some minor comments:

  1. Remove the .DS_Store file and add an exception to .gitignore for it.
  2. the example from the readme uses a evt argument for recordEvent(). Maybe it can be more explicit what it is?
  3. An example to showcase how the Selenium adapter works would be good to have as well.
  4. For the Selenium adapter the driver has the browser name and version as part of the capabilities so there is no need to hard-code their values.

Feel free to apply or ignore. Do you plan to move to the Firefox DevTools org before closing this bug?

Thanks for the feedback! I will apply the comments and push a PR soon.
Honza: do you think it's ok to move the repository under the firefox-devtools org?

Flags: needinfo?(odvarko)

PR up at https://github.com/juliandescottes/bidi-har-export/pull/3 , let me know if you want to take a look before I merge

(In reply to Julian Descottes [:jdescottes] from comment #4)

Honza: do you think it's ok to move the repository under the firefox-devtools org?

Yes, I think so, please.

Flags: needinfo?(odvarko)

The bidi-har-export module can now be found at https://github.com/firefox-devtools/bidi-har-export

The last version (v0.0.3) has been integrated in https://github.com/firefox-devtools/bidi-webconsole-prototype and in https://github.com/sitespeedio/browsertime/tree/ff-har-pro

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Component: Netmonitor → WebDriver BiDi
Product: DevTools → Remote Protocol
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.